chore(turbopack): Remove or improve a few uses of `.to_resolved().awa…

…it` inside a loop (#74112)

- We should generally prefer `try_join` over `to_resolved().await` in a loop as it can provide more parallelism.
- Some of these should just resolve the `Vc` outside the loop.

turbopack/crates/turbopack-browser/src/ecmascript/evaluate/chunk.rs

@@ -218,9 +218,14 @@ impl OutputAsset for EcmascriptDevEvaluateChunk {
                 .await?,
         );
 
-        for chunk in &*self.other_chunks.await? {
-            ident.add_modifier(chunk.ident().to_string().to_resolved().await?);
-        }
+        ident.modifiers.extend(
+            self.other_chunks
+                .await?
+                .iter()
+                .map(|chunk| chunk.ident().to_string().to_resolved())
+                .try_join()
+                .await?,
+        );
 
         let ident = AssetIdent::new(Value::new(ident));
         Ok(AssetIdent::from_path(

turbopack/crates/turbopack-core/src/introspect/utils.rs

@@ -92,6 +92,7 @@ pub async fn children_from_module_references(
             }
         }
 
+        let key = key.to_resolved().await?;
         for &module in reference
             .resolve_reference()
             .resolve()
@@ -100,18 +101,15 @@ pub async fn children_from_module_references(
             .await?
             .iter()
         {
-            children.insert((key.to_resolved().await?, IntrospectableModule::new(*module)));
+            children.insert((key, IntrospectableModule::new(*module)));
         }
         for &output_asset in reference
             .resolve_reference()
             .primary_output_assets()
             .await?
             .iter()
         {
-            children.insert((
-                key.to_resolved().await?,
-                IntrospectableOutputAsset::new(*output_asset),
-            ));
+            children.insert((key, IntrospectableOutputAsset::new(*output_asset)));
         }
     }
     Ok(Vc::cell(children))
@@ -121,12 +119,12 @@ pub async fn children_from_module_references(
 pub async fn children_from_output_assets(
     references: Vc<OutputAssets>,
 ) -> Result<Vc<IntrospectableChildren>> {
-    let key = reference_ty();
+    let key = reference_ty().to_resolved().await?;
     let mut children = FxIndexSet::default();
     let references = references.await?;
     for &reference in &*references {
         children.insert((
-            key.to_resolved().await?,
+            key,
             IntrospectableOutputAsset::new(*ResolvedVc::upcast(reference)),
         ));
     }

turbopack/crates/turbopack-css/src/chunk/mod.rs

@@ -254,8 +254,6 @@ fn chunk_item_key() -> Vc<RcStr> {
 impl OutputAsset for CssChunk {
     #[turbo_tasks::function]
     async fn ident(&self) -> Result<Vc<AssetIdent>> {
-        let mut assets = Vec::new();
-
         let CssChunkContent { chunk_items, .. } = &*self.content.await?;
         let mut common_path = if let Some(chunk_item) = chunk_items.first() {
             let path = chunk_item.asset_ident().path().to_resolved().await?;
@@ -266,7 +264,7 @@ impl OutputAsset for CssChunk {
 
         // The included chunk items and the availability info describe the chunk
         // uniquely
-        let chunk_item_key = chunk_item_key();
+        let chunk_item_key = chunk_item_key().to_resolved().await?;
         for &chunk_item in chunk_items.iter() {
             if let Some((common_path_vc, common_path_ref)) = common_path.as_mut() {
                 let path = chunk_item.asset_ident().path().await?;
@@ -280,11 +278,17 @@ impl OutputAsset for CssChunk {
                     *common_path_ref = (*common_path_vc).await?;
                 }
             }
-            assets.push((
-                chunk_item_key.to_resolved().await?,
-                chunk_item.content_ident().to_resolved().await?,
-            ));
         }
+        let assets = chunk_items
+            .iter()
+            .map(|chunk_item| async move {
+                Ok((
+                    chunk_item_key,
+                    chunk_item.content_ident().to_resolved().await?,
+                ))
+            })
+            .try_join()
+            .await?;
 
         let ident = AssetIdent {
             path: if let Some((common_path, _)) = common_path {

turbopack/crates/turbopack-ecmascript/src/chunk/mod.rs

@@ -75,8 +75,6 @@ fn availability_root_key() -> Vc<RcStr> {
 impl Chunk for EcmascriptChunk {
     #[turbo_tasks::function]
     async fn ident(&self) -> Result<Vc<AssetIdent>> {
-        let mut assets = Vec::new();
-
         let EcmascriptChunkContent { chunk_items, .. } = &*self.content.await?;
         let mut common_path = if let Some((chunk_item, _)) = chunk_items.first() {
             let path = chunk_item.asset_ident().path().to_resolved().await?;
@@ -86,7 +84,6 @@ impl Chunk for EcmascriptChunk {
         };
 
         // The included chunk items describe the chunk uniquely
-        let chunk_item_key = chunk_item_key();
         for &(chunk_item, _) in chunk_items.iter() {
             if let Some((common_path_vc, common_path_ref)) = common_path.as_mut() {
                 let path = chunk_item.asset_ident().path().await?;
@@ -100,13 +97,19 @@ impl Chunk for EcmascriptChunk {
                     *common_path_ref = (*common_path_vc).await?;
                 }
             }
-            assets.push((
-                chunk_item_key.to_resolved().await?,
-                chunk_item.content_ident().to_resolved().await?,
-            ));
         }
 
-        // The previous resolve loop is no longer needed since we're already using ResolvedVc
+        let chunk_item_key = chunk_item_key().to_resolved().await?;
+        let assets = chunk_items
+            .iter()
+            .map(|&(chunk_item, _)| async move {
+                Ok((
+                    chunk_item_key,
+                    chunk_item.content_ident().to_resolved().await?,
+                ))
+            })
+            .try_join()
+            .await?;
 
         let ident = AssetIdent {
             path: if let Some((common_path, _)) = common_path {