react-sync: cleanup inaccurate peer dependencies

vercel · Aug 30, 2024 · c2b493b · c2b493b
1 parent 3d49428
commit c2b493b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/packages/next/package.json b/packages/next/package.json
@@ -108,8 +108,8 @@
     "@opentelemetry/api": "^1.1.0",
     "@playwright/test": "^1.41.2",
     "babel-plugin-react-compiler": "*",
-    "react": "19.0.0-rc-7771d3a7-20240827",
-    "react-dom": "19.0.0-rc-7771d3a7-20240827",
+    "react": "^18.0.0 || 19.0.0-rc-7771d3a7-20240827",
+    "react-dom": "^18.0.0 || 19.0.0-rc-7771d3a7-20240827",
     "sass": "^1.3.0"
   },
   "peerDependenciesMeta": {

diff --git a/packages/next/src/build/webpack-config.ts b/packages/next/src/build/webpack-config.ts
@@ -108,8 +108,8 @@ const NEXT_PROJECT_ROOT_DIST_CLIENT = path.join(
   'client'
 )
 
-if (parseInt(React.version) < 19) {
-  throw new Error('Next.js requires react >= 19.0.0 to be installed.')
+if (parseInt(React.version) < 18) {
+  throw new Error('Next.js requires react >= 18.2.0 to be installed.')
 }
 
 export const babelIncludeRegexes: RegExp[] = [

diff --git a/run-tests.js b/run-tests.js
@@ -18,9 +18,10 @@ const exec = promisify(execOrig)
 const core = require('@actions/core')
 const { getTestFilter } = require('./test/get-test-filter')
 
+// TODO: Base this off of test matrix
 // Do not rename or format. sync-react script relies on this line.
 // prettier-ignore
-const nextjsReactPeerVersion = "19.0.0-rc-7771d3a7-20240827";
+const nextjsReactPeerVersion = "^18.0.0";
 
 let argv = require('yargs/yargs')(process.argv.slice(2))
   .string('type')

diff --git a/test/lib/next-modes/base.ts b/test/lib/next-modes/base.ts
@@ -49,9 +49,10 @@ type OmitFirstArgument<F> = F extends (
   ? (...args: P) => R
   : never
 
+// TODO: Base this off of test matrix
 // Do not rename or format. sync-react script relies on this line.
 // prettier-ignore
-const nextjsReactPeerVersion = "19.0.0-rc-7771d3a7-20240827";
+const nextjsReactPeerVersion = "18.0.0";
 
 export class NextInstance {
   protected files: FileRef | { [filename: string]: string | FileRef }