still log if error is not network error

vercel · Feb 15, 2024 · e1a5857 · e1a5857
1 parent 20f78aa
commit e1a5857
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/packages/next/src/server/dev/hot-reloader-webpack.ts b/packages/next/src/server/dev/hot-reloader-webpack.ts
@@ -191,6 +191,14 @@ function erroredPages(compilation: webpack.Compilation) {
   return failedPages
 }
 
+const networkErrors = [
+  'EADDRINFO',
+  'ENOTFOUND',
+  'ETIMEDOUT',
+  'ECONNREFUSED',
+  'EAI_AGAIN',
+]
+
 export async function getVersionInfo(enabled: boolean): Promise<VersionInfo> {
   let installed = '0.0.0'
 
@@ -206,14 +214,11 @@ export async function getVersionInfo(enabled: boolean): Promise<VersionInfo> {
 
     if (!res.ok) return { installed, staleness: 'unknown' }
 
-    const tags = await res.json()
+    const { latest, canary } = await res.json()
 
-    return parseVersionInfo({
-      installed,
-      latest: tags.latest,
-      canary: tags.canary,
-    })
-  } catch {
+    return parseVersionInfo({ installed, latest, canary })
+  } catch (e: any) {
+    if (!networkErrors.includes(e?.code)) console.error(e)
     return { installed, staleness: 'unknown' }
   }
 }

diff --git a/test/development/acceptance-app/version-staleness.test.ts b/test/development/acceptance-app/version-staleness.test.ts
@@ -7,10 +7,6 @@ import { outdent } from 'outdent'
 describe('Error Overlay version staleness', () => {
   const { next } = nextTestSetup({
     files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
-    dependencies: {
-      react: 'latest',
-      'react-dom': 'latest',
-    },
     skipStart: true,
   })