add comment for app-ssr condition

vercel · Jun 19, 2024 · f7bf8ee · f7bf8ee
1 parent 28736e2
commit f7bf8ee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/packages/next-swc/crates/next-core/src/next_server/context.rs b/packages/next-swc/crates/next-core/src/next_server/context.rs
@@ -180,6 +180,7 @@ pub async fn get_server_resolve_options_context(
         project_path,
         project_path.root(),
         ExternalPredicate::Only(Vc::cell(external_packages)).cell(),
+        // app-ssr can't have esm externals as that would make the module async on the server only
         *next_config.import_externals().await? && !matches!(ty, ServerContextType::AppSSR { .. }),
     );
 

diff --git a/test/turbopack-dev-tests-manifest.json b/test/turbopack-dev-tests-manifest.json
@@ -6118,9 +6118,7 @@
       "esm-externals should return the correct SSR HTML for /ssr",
       "esm-externals should return the correct SSR HTML for /static"
     ],
-    "failed": [
-      "esm-externals app url /client should return the correct SSR HTML"
-    ],
+    "failed": [],
     "pending": [],
     "flakey": [],
     "runtimeError": false