No HTML compression via custom server & app.render()

[bobaaaaa]

Bug report

Describe the bug

If you write custom server routes via app.render() there is no gzip compression for the HTML document. I looked at the source code: the handleCompression() fn is only called via the app.getRequestHandler(). I guess this is not intended.

next.js/packages/next/next-server/server/next-server.ts

Lines 866 to 872 in 8efc8be

	public async render(
	req: IncomingMessage,
	res: ServerResponse,
	pathname: string,
	query: ParsedUrlQuery = {},
	parsedUrl?: UrlWithParsedQuery
	): Promise<void> {

To Reproduce

1. Clone the custom-server example (yarn create next-app --example custom-server custom-server-app)
2. yarn build && yarn start
3. Route to http://localhost:3000/a inspect HTML document response header via chrome dev tools or cURL
4. There is no Content-Encoding: gzip response header 👎
5. Route to index http://localhost:3000/ inspect HTML document response header via chrome dev tools or cURL
6. Content-Encoding: gzip response header available 👍

Expected behavior

• gzip compression of HTML documents rendered via app.render()
• Response Header: Content-Encoding: gzip

System information

• OS: macOS
• Version of Next.js: 9.5.2
• Version of Node.js: 12.18.2

[YichiZ]

Hey,

I am going to try this out. Just to be clear, what you mean is that there should be an Content-Encoding: gzip in the Response Headers like this:

But this is not on the sub pages:

[bobaaaaa]

@YichiZ exactly

[shobhitsharma]

@timneutkens Is the related bug or PR is manageable to have this resolved?

[timneutkens]

The open PR has failing tests and no new tests added. Feel free to open a new PR that does have an integration test 👍

[radoslawgrochowski]

I've added test cases, @timneutkens.

I have one question - should app.render with /static content also be compressed?

[balazsorban44]

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.