React 18: Separate concurrentFeatures and runtime options
#31317
Assignees
Comments
|
Separating the concurrent and runtime features would be great, as it’s trivial to hit the 1MB limit of the vercel edge runtime #32907 and break your app |
2 tasks
|
Heyo, this is an awesome feature, thanks. Just want to flag this here since we are experimenting with Relay + SSR Suspense: #32502 (comment) |
kodiakhq bot
pushed a commit
that referenced
this issue
Mar 8, 2022
Partially implements #31317 and #31506. There're also some trade-offs made with this PR: since we can't know if a certain runtime will be used or not beforehand, we have to start both runtime compilers (Node.js and Edge) and then generate entrypoints correspondingly. Note that with this PR, the global runtime is still required to use the per-page runtime. ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
This was referenced Mar 11, 2022
kodiakhq bot
pushed a commit
that referenced
this issue
Mar 11, 2022
Previously we only run `PagesManifestPlugin` in the Node server runtime, because the Edge target doesn't need it as the web server and middleware SSR loader specially handled pages manifest. This cases entrypoints with the Edge runtime configured being missing from there and this PR fixes it. Part of #31317 and #31506. ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
kodiakhq bot
pushed a commit
that referenced
this issue
Mar 16, 2022
…35245) This PR depends on #35242 and #35243. It allows the global runtime to be unset, as well as enables static optimization for Fizz and RSC pages in the Node.js runtime. Currently for the Edge runtime pages are still always SSR'd. Closes #31317. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint` Co-authored-by: Jiachi Liu <4800338+huozhi@users.noreply.github.com>
|
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add the global experimentalruntimeflag to switch the default runtime. Ifruntimeis set, we enable Fizz for all pages. It works similar to theconcurrentFeaturesflag. Ifruntimeis missing, Fizz will not be enabled.Add support fornodejsruntime. (@shuding)RemoveconcurrentFeaturesfrom the config but keep it internal. It will be disabled for now.runtimeflag to enable Fizz for specific pages. The globalruntimewill now not affect all pages.runtimeto be unset. (@shuding)The text was updated successfully, but these errors were encountered: