Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next build perf issue with long string .concat function #65512

Open
zombieJ opened this issue May 8, 2024 · 1 comment
Open

Next build perf issue with long string .concat function #65512

zombieJ opened this issue May 8, 2024 · 1 comment
Labels
bug Issue was opened via the bug report template. linear: next Confirmed issue that is tracked by the Next.js team. Performance Anything with regards to Next.js performance.

Comments

@zombieJ
Copy link

zombieJ commented May 8, 2024

Link to the code that reproduces this issue

ant-design/ant-design#48758

To Reproduce

Hi, I'm the member of antd team. Recently get report with build perf issue of Next.js:

ant-design/ant-design#48758

After dig, found that Next.js has the perf issue with long string .concat function. Pls help to check on this. Here is the workaround PR on antd side:

react-component/async-validator#9

The research report (PR background part):

ant-design/ant-design#48829

Current vs. Expected behavior

Generating static file as fast as expected.

Provide environment information

Operating System:
  Platform: darwin
  Arch: x64
  Version: Darwin Kernel Version 23.4.0: Fri Mar 15 00:12:41 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T8103
  Available memory (MB): 16384
  Available CPU cores: 8
Binaries:
  Node: 18.19.1
  npm: 10.2.4
  Yarn: 1.22.21
  pnpm: 8.15.7
Relevant Packages:
  next: 14.2.3 // Latest available version is detected (14.2.3).
  eslint-config-next: N/A
  react: 18.3.1
  react-dom: 18.3.1
  typescript: 5.4.5
Next.js Config:
  output: N/A

Which area(s) are affected? (Select all that apply)

Performance

Which stage(s) are affected? (Select all that apply)

next build

Additional context

No response

@zombieJ zombieJ added the bug Issue was opened via the bug report template. label May 8, 2024
@github-actions github-actions bot added the Performance Anything with regards to Next.js performance. label May 8, 2024
@github-actions github-actions bot added the linear: next Confirmed issue that is tracked by the Next.js team. label May 13, 2024
@feedthejim
Copy link
Contributor

thanks for reporting, we identified it to an issue with node-file-trace, but we're still unsure why concat messes with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue was opened via the bug report template. linear: next Confirmed issue that is tracked by the Next.js team. Performance Anything with regards to Next.js performance.
Projects
None yet
Development

No branches or pull requests

2 participants