Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: next build lagging #9

Merged
merged 2 commits into from
May 8, 2024
Merged

fix: next build lagging #9

merged 2 commits into from
May 8, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 8, 2024

NextJS will build long time when code has .concat:

// More `.concat` has, more lag of it
'a'.concat(b, 'c').concat(d, 'e')...

Since it's build from babel, we can not destruct this without configuration. Modify with list join instead.

ref ant-design/ant-design#48758

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.36%. Comparing base (8dbf489) to head (8d538e5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   82.30%   82.36%   +0.05%     
==========================================
  Files          25       25              
  Lines         650      652       +2     
  Branches      236      232       -4     
==========================================
+ Hits          535      537       +2     
  Misses        114      114              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 7309d8d into master May 8, 2024
6 checks passed
@zombieJ zombieJ deleted the fix-next branch May 8, 2024 10:02
];
const v6Eth0 = `(?:%[0-9a-zA-Z]{1,})?`; // %eth0 %1

const v6 = `(?:${v6List.join('|')})${v6Eth0}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

怎么发现的。。

@MadCcc
Copy link
Member

MadCcc commented May 8, 2024

我记得以前是不是编译成 '+' 来减小包体积来着?

@zombieJ
Copy link
Member Author

zombieJ commented May 8, 2024

我记得以前是不是编译成 '+' 来减小包体积来着?

那个是 antd 侧的,rc 侧还是保持兼容态。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants