Not found icon and apple-icon with slots from canary.107
#68650
Comments
|
@Marukome0743 Thank you for submitting an issue! Can confirm that PR caused this regression. Our team will be taking a look! |
|
This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
lubieowoce
pushed a commit
that referenced
this issue
Sep 2, 2024
### What Collect static metadata icons from the most leaf node in the component tree, and then add them into resolved metadata icons if there's no icons presented in exported metadata ### Why Previously we collected the icons from the last item from collected metadata items as last segment in the tree. But it doesn't act like that when there's parallel routes, so we collect the last presented static metadata icons from the metadata item list and then merge into the resolved metadata at the end. Fixes #68650
lubieowoce
pushed a commit
that referenced
this issue
Sep 2, 2024
### What Collect static metadata icons from the most leaf node in the component tree, and then add them into resolved metadata icons if there's no icons presented in exported metadata ### Why Previously we collected the icons from the last item from collected metadata items as last segment in the tree. But it doesn't act like that when there's parallel routes, so we collect the last presented static metadata icons from the metadata item list and then merge into the resolved metadata at the end. Fixes #68650
lubieowoce
pushed a commit
that referenced
this issue
Sep 2, 2024
### What Collect static metadata icons from the most leaf node in the component tree, and then add them into resolved metadata icons if there's no icons presented in exported metadata ### Why Previously we collected the icons from the last item from collected metadata items as last segment in the tree. But it doesn't act like that when there's parallel routes, so we collect the last presented static metadata icons from the metadata item list and then merge into the resolved metadata at the end. Fixes #68650
lubieowoce
pushed a commit
that referenced
this issue
Sep 2, 2024
### What Collect static metadata icons from the most leaf node in the component tree, and then add them into resolved metadata icons if there's no icons presented in exported metadata ### Why Previously we collected the icons from the last item from collected metadata items as last segment in the tree. But it doesn't act like that when there's parallel routes, so we collect the last presented static metadata icons from the metadata item list and then merge into the resolved metadata at the end. Fixes #68650
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Link to the code that reproduces this issue
https://github.com/Marukome0743/not-found-icons
To Reproduce
create-next-app@canaryiconandapple-iconimages to app folder@modalnext dev<head>tag components and only showfavicon.icoCurrent vs. Expected behavior
Current
Expected
Provide environment information
Operating System: Platform: linux Arch: x64 Version: #1 SMP PREEMPT_DYNAMIC Sat Jun 29 07:01:04 UTC 2024 Available memory (MB): 15881 Available CPU cores: 8 Binaries: Node: 22.5.1 npm: 10.8.2 Yarn: N/A pnpm: N/A Relevant Packages: next: 15.0.0-canary.108 // Latest available version is detected (15.0.0-canary.108). eslint-config-next: N/A react: 19.0.0-rc-06d0b89e-20240801 react-dom: 19.0.0-rc-06d0b89e-20240801 typescript: N/A Next.js Config: output: N/AWhich area(s) are affected? (Select all that apply)
Metadata
Which stage(s) are affected? (Select all that apply)
next dev (local)
Additional context
This issue has happend since Fix favicon merging with customized icons commit.
The all icons appear unless slots exist.
The text was updated successfully, but these errors were encountered: