pass-server-data example: Use API Routes?

[karlhorky]

Examples bug report

Example name

pass-server-data

Describe the bug

So not as much of a bug as a suggestion of a potential improvement:

The data is currently being required and passed to the pages by a custom server.js file that uses Express.

Would the Next.js team be open to migrating this example to use API Routes? Maybe with an implementation along the lines of React Tricks: Exploring Next.js 9 Dynamic Routing & API Routes?

Alternatives

A potential alternative (which would allow retaining the current version of pass-server-data as it is for reference) would be to copy and rename this example to create a new example that did use API Routes.

To Reproduce

Not applicable

Expected behavior

Example uses API Routes

System information

Not Applicable

Additional context

[timneutkens]

I think the example should be removed, it shows a bunch of bad practices.

[karlhorky]

Ah, ok! Can you list these other bad practices out?

Maybe these two tasks could be done at the same time? Eg:

1. Convert the example to use API Routes
2. Refactor the example to remove bad practices

[timneutkens]

The goal of the example is showing passing data as the querystring which in general you don't want to do, getInitialProps covers fetching data. Furthermore that'd break client-side route transitions as there is no data available when switching pages.

[karlhorky]

Ok, so if I was to rework the example in the way described in the blog post, this would be acceptable?

TLDR version:

• Set up an API route page that requires the data
• isomorphic-unfetch from that API route in getInitialProps

[timneutkens]

I guess that might work, but that's already covered here: https://github.com/zeit/next.js/tree/canary/examples/api-routes

[karlhorky]

Ok great! Don't need to do anything except remove the pass-server-data example then!

Should I open a PR to do this?

[timneutkens]

Sure!

[balazsorban44]

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.