Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the version of styled-components #1038

Closed
wants to merge 5 commits into from
Closed

Upgrade the version of styled-components #1038

wants to merge 5 commits into from

Conversation

sandiiarov
Copy link

No description provided.

timneutkens
timneutkens reviewed Feb 8, 2017
View reviewed changes
examples/with-styled-components/pages/_document.js
@@ -13,6 +15,10 @@ export default class MyDocument extends Document {
<html>
<Head>
<title>My page</title>
<link
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use a webfont? 🤔

@timneutkens
Copy link
Member

styled-components 2.0 is still in alpha/beta right? Should we be upgrading right now? 🤔

@arunoda
Copy link
Contributor

arunoda commented Feb 8, 2017

@timneutkens yep.
@Alex4s let's do this after they released it.

Basically, we wanted to show about how to use styled-components. I think that idea is there even someone is using the latest beta of styled-components.

@timneutkens
Copy link
Member

timneutkens commented Feb 9, 2017 •
edited
Loading

@arunoda FYI in styled-components 2.0 this is fixed https://github.com/zeit/next.js/tree/master/examples/with-styled-components#notes.

@sandiiarov
Copy link
Author

@timneutkens styled-components 2.0 is pre-release now and you are right this issue is fixed.

@timneutkens timneutkens mentioned this pull request Feb 17, 2017
Closed
@alexedev
Copy link

alexedev commented Feb 23, 2017 •
edited
Loading

has different client/server classes in 2.0.0-1
screen shot 2017-02-23 at 17 57 31

@davidrossjones
Copy link
Contributor

@alexedev Same for me. Issue reported here: styled-components/styled-components#513

@timneutkens timneutkens added the examples Issue/PR related to examples label Feb 27, 2017
@robertvansteen
Copy link
Contributor

robertvansteen commented Mar 14, 2017 •
edited
Loading

Fyi, the version currently used in the example breaks when using ThemeProvider so it might be good idea to update it to the latest 1.x version, even tho 2.x will be released soon.

See: #1416

@timneutkens
Copy link
Member

@rovansteen I'll do that 👍

@timneutkens timneutkens added this to the 2.1 milestone Mar 15, 2017
@timneutkens timneutkens closed this May 7, 2017
@lock lock bot locked as resolved and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens left review comments

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sandiiarov @timneutkens @arunoda @alexedev @davidrossjones @robertvansteen