Ensure catch-all routes 404 for index route #10502

Janpot · 2020-02-12T06:54:26Z

This used to give a 500 in dev environment

ijjk · 2020-02-12T07:00:07Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
buildDuration	11.2s	11.3s	⚠️ +65ms
nodeModulesSize	52.9 MB	52.9 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..e781.js gzip	13.8 kB	13.8 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.module.js gzip	4.13 kB	4.13 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
index.html gzip	1.03 kB	1.03 kB	✓
link.html gzip	1.04 kB	1.04 kB	✓
withRouter.html gzip	1.03 kB	1.03 kB	✓
Overall change	3.11 kB	3.11 kB	✓

Serverless Mode (Decrease detected ✓)

General

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
buildDuration	12.3s	12.1s	-143ms
nodeModulesSize	52.9 MB	52.9 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..e781.js gzip	13.8 kB	13.8 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.module.js gzip	4.13 kB	4.13 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_error.js gzip	290 kB	289 kB	-1 kB
404.html gzip	1.45 kB	1.45 kB	✓
hooks.html gzip	1.08 kB	1.08 kB	✓
index.js gzip	289 kB	290 kB	⚠️ +696 B
link.js gzip	320 kB	319 kB	-773 B
routerDirect.js gzip	317 kB	316 kB	-192 B
withRouter.js gzip	317 kB	317 kB	⚠️ +312 B
Overall change	1.53 MB	1.53 MB	-958 B

Commit: dbeaa5a

ijjk · 2020-02-15T09:13:49Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
buildDuration	12.6s	12.7s	⚠️ +87ms
nodeModulesSize	52.7 MB	52.7 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d239.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	70 kB	70 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.module.js gzip	4.13 kB	4.13 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.6 kB	64.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
index.html gzip	1.03 kB	1.03 kB	✓
link.html gzip	1.04 kB	1.04 kB	✓
withRouter.html gzip	1.03 kB	1.03 kB	✓
Overall change	3.11 kB	3.11 kB	✓

Serverless Mode (Decrease detected ✓)

General

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
buildDuration	13.7s	13.4s	-351ms
nodeModulesSize	52.7 MB	52.7 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d239.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	70 kB	70 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.module.js gzip	4.13 kB	4.13 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.6 kB	64.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_error.js gzip	290 kB	289 kB	-1.15 kB
404.html gzip	1.44 kB	1.44 kB	✓
hooks.html gzip	1.08 kB	1.08 kB	✓
index.js gzip	290 kB	290 kB	⚠️ +399 B
link.js gzip	319 kB	319 kB	-476 B
routerDirect.js gzip	316 kB	315 kB	-1.13 kB
withRouter.js gzip	317 kB	316 kB	-442 B
Overall change	1.53 MB	1.53 MB	-2.79 kB

Commit: 4e0faea

ijjk · 2020-02-16T12:37:08Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
buildDuration	11.5s	11.5s	⚠️ +24ms
nodeModulesSize	52.7 MB	52.7 MB	⚠️ +323 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.js gzip	5.14 kB	5.14 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..4e43.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	70 kB	70 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.7 kB	64.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
index.html gzip	1.03 kB	1.03 kB	✓
link.html gzip	1.04 kB	1.04 kB	✓
withRouter.html gzip	1.03 kB	1.03 kB	✓
Overall change	3.11 kB	3.11 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
buildDuration	12.3s	12.4s	⚠️ +143ms
nodeModulesSize	52.7 MB	52.7 MB	⚠️ +323 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.js gzip	5.14 kB	5.14 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..4e43.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	70 kB	70 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.7 kB	64.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_error.js gzip	290 kB	289 kB	-352 B
404.html gzip	1.45 kB	1.45 kB	✓
hooks.html gzip	1.08 kB	1.08 kB	✓
index.js gzip	289 kB	290 kB	⚠️ +680 B
link.js gzip	319 kB	319 kB	-797 B
routerDirect.js gzip	316 kB	316 kB	-26 B
withRouter.js gzip	315 kB	316 kB	⚠️ +1.13 kB
Overall change	1.53 MB	1.53 MB	⚠️ +638 B

Commit: aa6e63d

because it's interferring with the other routes

ijjk · 2020-02-16T14:57:32Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
buildDuration	11.4s	11.1s	-305ms
nodeModulesSize	52.7 MB	52.7 MB	⚠️ +323 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.js gzip	5.14 kB	5.14 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..4e43.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	70 kB	70 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.7 kB	64.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
index.html gzip	1.03 kB	1.03 kB	✓
link.html gzip	1.04 kB	1.04 kB	✓
withRouter.html gzip	1.03 kB	1.03 kB	✓
Overall change	3.11 kB	3.11 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
buildDuration	12.1s	12.1s	⚠️ +43ms
nodeModulesSize	52.7 MB	52.7 MB	⚠️ +323 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.js gzip	5.14 kB	5.14 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..4e43.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	70 kB	70 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.7 kB	64.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_error.js gzip	290 kB	290 kB	-90 B
404.html gzip	1.45 kB	1.45 kB	✓
hooks.html gzip	1.08 kB	1.08 kB	✓
index.js gzip	289 kB	289 kB	⚠️ +171 B
link.js gzip	319 kB	319 kB	⚠️ +220 B
routerDirect.js gzip	316 kB	316 kB	⚠️ +578 B
withRouter.js gzip	315 kB	317 kB	⚠️ +1.28 kB
Overall change	1.53 MB	1.53 MB	⚠️ +2.16 kB

Commit: ad7059e

ijjk · 2020-02-16T15:27:13Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
buildDuration	10.9s	10.8s	-67ms
nodeModulesSize	52.7 MB	52.7 MB	⚠️ +323 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.js gzip	5.14 kB	5.14 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..4e43.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	70 kB	70 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.7 kB	64.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
index.html gzip	1.03 kB	1.03 kB	✓
link.html gzip	1.04 kB	1.04 kB	✓
withRouter.html gzip	1.03 kB	1.03 kB	✓
Overall change	3.11 kB	3.11 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
buildDuration	11.7s	11.6s	-129ms
nodeModulesSize	52.7 MB	52.7 MB	⚠️ +323 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.js gzip	5.14 kB	5.14 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..4e43.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	70 kB	70 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.7 kB	64.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_error.js gzip	289 kB	289 kB	-102 B
404.html gzip	1.45 kB	1.45 kB	✓
hooks.html gzip	1.08 kB	1.08 kB	✓
index.js gzip	290 kB	290 kB	⚠️ +37 B
link.js gzip	319 kB	318 kB	-688 B
routerDirect.js gzip	317 kB	317 kB	-32 B
withRouter.js gzip	315 kB	316 kB	⚠️ +997 B
Overall change	1.53 MB	1.53 MB	⚠️ +212 B

Commit: e14a70d

bthecorgi · 2020-05-13T16:07:28Z

can this be merged?

ijjk · 2020-05-18T16:21:36Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
buildDuration	12s	12.1s	⚠️ +151ms
nodeModulesSize	58.6 MB	58.6 MB	⚠️ +189 B

Page Load Tests Overall increase ✓

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.934	1.983	⚠️ +0.05
/ avg req/sec	1292.51	1260.85	-31.66
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.149	1.093	-0.06
/error-in-render avg req/sec	2175.15	2288.32	⚠️ +113.17

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.js gzip	6.71 kB	6.71 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..fc14.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.module.js gzip	5.74 kB	5.74 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.28 kB	3.28 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.26 kB	8.26 kB	✓

Client Pages Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
index.html gzip	926 B	926 B	✓
link.html gzip	936 B	936 B	✓
withRouter.html gzip	923 B	923 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
buildDuration	12.8s	12.5s	-358ms
nodeModulesSize	58.6 MB	58.6 MB	⚠️ +189 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.js gzip	6.71 kB	6.71 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..fc14.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
main-HASH.module.js gzip	5.74 kB	5.74 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.28 kB	3.28 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.26 kB	8.26 kB	✓

Client Pages Modern

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	Janpot/next.js catch-all-404	Change
_error.js	850 kB	850 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	851 kB	851 kB	✓
link.js	888 kB	888 kB	✓
routerDirect.js	880 kB	880 kB	✓
withRouter.js	880 kB	880 kB	✓
Overall change	4.36 MB	4.36 MB	✓

ijjk · 2020-05-18T16:22:51Z

Failing test suites

test/integration/api-catch-all/test/index.test.js

Expand output

● Test suite failed to run

ReferenceError: jasmine is not defined

  12 | } from 'next-test-utils'
  13 | 
> 14 | jasmine.DEFAULT_TIMEOUT_INTERVAL = 1000 * 60 * 2
     | ^
  15 | const appDir = join(__dirname, '../')
  16 | const nextConfig = join(appDir, 'next.config.js')
  17 | let appPort

  at Object.<anonymous> (integration/api-catch-all/test/index.test.js:14:1)

test/integration/api-catch-all/test/index.test.js

Janpot · 2020-05-18T17:54:21Z

@Timer Please don't merge yet, I'm going to revisit this PR. As discussed with @timneutkens we'll let trailing slash and non-trailing slash match to the same route and forbid directly accessing /index. This PR is not in line yet with that idea yet as it forbids accessing api routes with a trailing slash. I will expand this PR to regular pages.

…sh (vercel#10502) Failing test case for vercel#10488 (comment) This used to give a 500 in dev environment

Add failing test

dbeaa5a

Janpot requested review from ijjk, lfades, Timer and timneutkens as code owners February 12, 2020 06:54

Janpot mentioned this pull request Feb 12, 2020

Catch-all routes do not catch the root index route #10488

Closed

Merge branch 'canary' into catch-all-404

4e0faea

This seems to solve it

aa6e63d

Isolate test case

ad7059e

because it's interferring with the other routes

Janpot changed the title ~~Add failing test for catch-all with index route and trailing slash~~ Fix catch-all route + index.js in dev when accessed with trailing slash Feb 16, 2020

Merge branch 'canary' into catch-all-404

e14a70d

Merge branch 'canary' into catch-all-404

93a8a0f

timneutkens added the type: next label Apr 6, 2020

Janpot added 2 commits May 15, 2020 21:35

Merge branch 'canary' into catch-all-404

ded31ad

Merge branch 'canary' into catch-all-404

1f5fa90

Timer reviewed May 18, 2020

View reviewed changes

test/integration/api-catch-all/test/index.test.js Outdated Show resolved Hide resolved

test/integration/api-catch-all/test/index.test.js Outdated Show resolved Hide resolved

Apply suggestions from code review

2b0d9b5

Timer added this to the 9.4.2 milestone May 18, 2020

Merge branch 'canary' into catch-all-404

4b03060

Timer approved these changes May 18, 2020

View reviewed changes

Merge branch 'canary' into catch-all-404

c8b99c4

Timer added the ready to land label May 19, 2020

Merge branch 'canary' into catch-all-404

df7e2cc

kodiakhq bot merged commit 0d05904 into vercel:canary May 19, 2020

Janpot deleted the catch-all-404 branch May 19, 2020 18:03

chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020

Fix catch-all route + index.js in dev when accessed with trailing sla…

e90e09c

…sh (vercel#10502) Failing test case for vercel#10488 (comment) This used to give a 500 in dev environment

Timer changed the title ~~Fix catch-all route + index.js in dev when accessed with trailing slash~~ Ensure catch-all routes 404 for index route May 28, 2020

rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020

Fix catch-all route + index.js in dev when accessed with trailing sla…

4e76b9d

…sh (vercel#10502) Failing test case for vercel#10488 (comment) This used to give a 500 in dev environment

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure catch-all routes 404 for index route #10502

Ensure catch-all routes 404 for index route #10502

Janpot commented Feb 12, 2020 •

edited

Loading

ijjk commented Feb 12, 2020

ijjk commented Feb 15, 2020

ijjk commented Feb 16, 2020

ijjk commented Feb 16, 2020

ijjk commented Feb 16, 2020

bthecorgi commented May 13, 2020

ijjk commented May 18, 2020

ijjk commented May 18, 2020

Janpot commented May 18, 2020

Ensure catch-all routes 404 for index route #10502

Ensure catch-all routes 404 for index route #10502

Conversation

Janpot commented Feb 12, 2020 • edited Loading

ijjk commented Feb 12, 2020

Stats from current PR

ijjk commented Feb 15, 2020

Stats from current PR

ijjk commented Feb 16, 2020

Stats from current PR

ijjk commented Feb 16, 2020

Stats from current PR

ijjk commented Feb 16, 2020

Stats from current PR

bthecorgi commented May 13, 2020

ijjk commented May 18, 2020

Stats from current PR

ijjk commented May 18, 2020

Failing test suites

Janpot commented May 18, 2020

Janpot commented Feb 12, 2020 •

edited

Loading