Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default response code to 307 from 302 in docs #14947

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Change default response code to 307 from 302 in docs #14947

merged 1 commit into from
Jul 8, 2020

Conversation

botv
Copy link
Contributor

@botv botv commented Jul 7, 2020

Corrects status code in docs for the new res.redirect helper.

@botv botv changed the title Change default response code to 307 from 302 Change default response code to 307 from 302 in docs Jul 7, 2020
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ijjk
Copy link
Member

ijjk commented Jul 7, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary botv/next.js fix/redirect-docs Change
buildDuration 10.6s 10.8s ⚠️ +167ms
nodeModulesSize 66.1 MB 66.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary botv/next.js fix/redirect-docs Change
/ failed reqs 0 0
/ total time (seconds) 1.761 1.768 ⚠️ +0.01
/ avg req/sec 1419.5 1413.68 ⚠️ -5.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.129 1.165 ⚠️ +0.04
/error-in-render avg req/sec 2215.05 2146.22 ⚠️ -68.83
Client Bundles (main, webpack, commons)
vercel/next.js canary botv/next.js fix/redirect-docs Change
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..c646.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary botv/next.js fix/redirect-docs Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.1 kB 7.1 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary botv/next.js fix/redirect-docs Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary botv/next.js fix/redirect-docs Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Rendered Page Sizes
vercel/next.js canary botv/next.js fix/redirect-docs Change
index.html gzip 954 B 954 B
link.html gzip 960 B 960 B
withRouter.html gzip 946 B 946 B
Overall change 2.86 kB 2.86 kB

Serverless Mode
General
vercel/next.js canary botv/next.js fix/redirect-docs Change
buildDuration 11.4s 11.2s -162ms
nodeModulesSize 66.1 MB 66.1 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary botv/next.js fix/redirect-docs Change
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..c646.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary botv/next.js fix/redirect-docs Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.1 kB 7.1 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary botv/next.js fix/redirect-docs Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary botv/next.js fix/redirect-docs Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Serverless bundles
vercel/next.js canary botv/next.js fix/redirect-docs Change
_error.js 876 kB 876 kB
404.html 4.17 kB 4.17 kB
hooks.html 3.79 kB 3.79 kB
index.js 877 kB 877 kB
link.js 915 kB 915 kB
routerDirect.js 909 kB 909 kB
withRouter.js 909 kB 909 kB
Overall change 4.49 MB 4.49 MB
Commit: 78c147c

@Timer Timer merged commit 87ce591 into vercel:canary Jul 8, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants