Some changes to better support parameterized urls #1617
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been following this but I actually don't think it's possible with the current API get get parameters routing working with universal rendering (although I'm very happy to be wrong!).
I think these changes will allow it though:
renderOptions
to be passed to therender
method on the server - this means you can specify thepage
optiongetInitialProps
.In general it seems to me that extracting dynamic parts of the url would need to happen in
getInitialProps
as that happens on both client and server, probably using some shareable route config.Here is a super simple example of what I mean, but if it would help I could create a sample app somewhere.
routes.js
server.js
pages/posts.js