yarn dev regression fix, ncc revert #18861

guybedford · 2020-11-05T21:35:12Z

This fixes the current regression with an ncc revert for now.

I will continue to follow up with the ncc upgrade in #18860.

ijjk · 2020-11-05T21:45:03Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
buildDuration	13.9s	13.4s	-429ms
nodeModulesSize	87 MB	87 MB	-2 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.408	2.414	⚠️ +0.01
/ avg req/sec	1038.28	1035.78	⚠️ -2.5
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.298	1.26	-0.04
/error-in-render avg req/sec	1926.68	1983.49	+56.81

Client Bundles (main, webpack, commons)

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
677f882d2ed8..7d3b.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-7a348ff..641f.js gzip	7.37 kB	7.37 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.4 kB	58.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
677f882d2ed8..dule.js gzip	7.04 kB	7.04 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-00e5ec9..dule.js gzip	6.37 kB	6.37 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-fca3d..2eb1.js gzip	3.44 kB	3.44 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-a674d88..ccde.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-a4469f3..dule.js gzip	1.32 kB	1.32 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.41 kB	5.41 kB	✓

Client Build Manifests

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_buildManifest.js gzip	321 B	321 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	994 B	994 B	✓
Overall change	3 kB	3 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
buildDuration	15.8s	15.5s	-311ms
nodeModulesSize	87 MB	87 MB	-2 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
677f882d2ed8..7d3b.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-7a348ff..641f.js gzip	7.37 kB	7.37 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.4 kB	58.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
677f882d2ed8..dule.js gzip	7.04 kB	7.04 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-00e5ec9..dule.js gzip	6.37 kB	6.37 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-fca3d..2eb1.js gzip	3.44 kB	3.44 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-a674d88..ccde.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-a4469f3..dule.js gzip	1.32 kB	1.32 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.41 kB	5.41 kB	✓

Client Build Manifests

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_buildManifest.js gzip	321 B	321 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_error.js	1.07 MB	1.07 MB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.07 MB	1.07 MB	✓
link.js	1.12 MB	1.12 MB	✓
routerDirect.js	1.11 MB	1.11 MB	✓
withRouter.js	1.11 MB	1.11 MB	✓
Overall change	5.49 MB	5.49 MB	✓

Commit: a3681b5

ijjk · 2020-11-05T21:49:52Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
buildDuration	13.6s	13.6s	-6ms
nodeModulesSize	87 MB	87 MB	-2 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.456	2.565	⚠️ +0.11
/ avg req/sec	1017.86	974.54	⚠️ -43.32
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.36	1.344	-0.02
/error-in-render avg req/sec	1838.39	1860.65	+22.26

Client Bundles (main, webpack, commons)

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
677f882d2ed8..7d3b.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-7a348ff..641f.js gzip	7.37 kB	7.37 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.4 kB	58.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
677f882d2ed8..dule.js gzip	7.04 kB	7.04 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-00e5ec9..dule.js gzip	6.37 kB	6.37 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-fca3d..2eb1.js gzip	3.44 kB	3.44 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-a674d88..ccde.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-a4469f3..dule.js gzip	1.32 kB	1.32 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.41 kB	5.41 kB	✓

Client Build Manifests

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_buildManifest.js gzip	321 B	321 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	994 B	994 B	✓
Overall change	3 kB	3 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
buildDuration	15.1s	14.6s	-513ms
nodeModulesSize	87 MB	87 MB	-2 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
677f882d2ed8..7d3b.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-7a348ff..641f.js gzip	7.37 kB	7.37 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.4 kB	58.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
677f882d2ed8..dule.js gzip	7.04 kB	7.04 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-00e5ec9..dule.js gzip	6.37 kB	6.37 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-fca3d..2eb1.js gzip	3.44 kB	3.44 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-a674d88..ccde.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-a4469f3..dule.js gzip	1.32 kB	1.32 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.41 kB	5.41 kB	✓

Client Build Manifests

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_buildManifest.js gzip	321 B	321 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_error.js	1.07 MB	1.07 MB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.07 MB	1.07 MB	✓
link.js	1.12 MB	1.12 MB	✓
routerDirect.js	1.11 MB	1.11 MB	✓
withRouter.js	1.11 MB	1.11 MB	✓
Overall change	5.49 MB	5.49 MB	✓

Commit: 9cae072

ijjk · 2020-11-05T21:57:31Z

Failing test suites

Commit: a3681b5

test/integration/scss-modules/test/index.test.js

3rd Party CSS Module Support > should have compiled successfully
3rd Party CSS Module Support > should've emitted a single CSS file
3rd Party CSS Module Support > should've injected the CSS on server render
Basic SCSS Module Support > should have compiled successfully
Basic SCSS Module Support > should've emitted a single CSS file
Basic SCSS Module Support > should've injected the CSS on server render
CSS Module Composes Usage (Basic) > should have compiled successfully
CSS Module Composes Usage (Basic) > should've emitted a single CSS file
CSS Module Composes Usage (External) > should have compiled successfully
CSS Module Composes Usage (External) > should've emitted a single CSS file
Can hot reload CSS Module without losing state > should update CSS color without remounting
Catch-all Route CSS Module Usage > should have compiled successfully
Catch-all Route CSS Module Usage > should apply styles correctly
Catch-all Route CSS Module Usage > should've emitted a single CSS file
Dynamic Route CSS Module Usage > should have compiled successfully
Dynamic Route CSS Module Usage > should've emitted a single CSS file
Dynamic Route CSS Module Usage > should apply styles correctly
Has CSS Module in computed styles in Development > should have CSS for page
Has CSS Module in computed styles in Production > should have compiled successfully
Has CSS Module in computed styles in Production > should have CSS for page
Valid CSS Module Usage from within node_modules > should have compiled successfully
Valid CSS Module Usage from within node_modules > should've prerendered with relevant data
Valid CSS Module Usage from within node_modules > should've emitted a single CSS file
Valid Nested CSS Module Usage from within node_modules > should have compiled successfully
Valid Nested CSS Module Usage from within node_modules > should've prerendered with relevant data
Valid Nested CSS Module Usage from within node_modules > should've emitted a single CSS file

Expand output

● Basic SCSS Module Support › should have compiled successfully

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  40 | 
  41 |   it('should have compiled successfully', () => {
> 42 |     expect(code).toBe(0)
     |                  ^
  43 |     expect(stdout).toMatch(/Compiled successfully/)
  44 |   })
  45 | 

  at Object.<anonymous> (integration/scss-modules/test/index.test.js:42:18)

● Basic SCSS Module Support › should've emitted a single CSS file

ENOENT: no such file or directory, scandir '/home/runner/work/next.js/next.js/test/integration/scss-fixtures/basic-module/.next/static/css'

● Basic SCSS Module Support › should've injected the CSS on server render

FetchError: request to http://localhost:40861/ failed, reason: connect ECONNREFUSED 127.0.0.1:40861

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● 3rd Party CSS Module Support › should have compiled successfully

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

   96 | 
   97 |   it('should have compiled successfully', () => {
>  98 |     expect(code).toBe(0)
      |                  ^
   99 |     expect(stdout).toMatch(/Compiled successfully/)
  100 |   })
  101 | 

  at Object.<anonymous> (integration/scss-modules/test/index.test.js:98:18)

● 3rd Party CSS Module Support › should've emitted a single CSS file

ENOENT: no such file or directory, scandir '/home/runner/work/next.js/next.js/test/integration/scss-fixtures/3rd-party-module/.next/static/css'

● 3rd Party CSS Module Support › should've injected the CSS on server render

FetchError: request to http://localhost:41941/ failed, reason: connect ECONNREFUSED 127.0.0.1:41941

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Has CSS Module in computed styles in Development › should have CSS for page

JavascriptError: javascript error: Failed to execute 'getComputedStyle' on 'Window': parameter 1 is not of type 'Element'.
  (Session info: headless chrome=86.0.4240.183)

  149 |     const browser = await webdriver(appPort, '/')
  150 | 
> 151 |     const currentColor = await browser.eval(
      |                          ^
  152 |       `window.getComputedStyle(document.querySelector('#verify-red')).color`
  153 |     )
  154 |     expect(currentColor).toMatchInlineSnapshot(`"rgb(255, 0, 0)"`)

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
  at thenableWebDriverProxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at Object.<anonymous> (integration/scss-modules/test/index.test.js:151:26)

● Has CSS Module in computed styles in Production › should have compiled successfully

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  176 | 
  177 |   it('should have compiled successfully', () => {
> 178 |     expect(code).toBe(0)
      |                  ^
  179 |     expect(stdout).toMatch(/Compiled successfully/)
  180 |   })
  181 | 

  at Object.<anonymous> (integration/scss-modules/test/index.test.js:178:18)

● Has CSS Module in computed styles in Production › should have CSS for page

WebDriverError: unknown error: net::ERR_CONNECTION_REFUSED
  (Session info: headless chrome=86.0.4240.183)

  177 |   console.log(`\n> Loading browser with ${url}\n`)
  178 | 
> 179 |   await browser.get(url)
      |   ^
  180 |   console.log(`\n> Loaded browser with ${url}\n`)
  181 | 
  182 |   // Wait for application to hydrate

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
  at thenableWebDriverProxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at _default (lib/next-webdriver.js:179:3)
  at Object.<anonymous> (integration/scss-modules/test/index.test.js:183:21)

● Can hot reload CSS Module without losing state › should update CSS color without remounting

NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":"#text-input"}
  (Session info: headless chrome=86.0.4240.183)

  208 | 
  209 |     const desiredText = 'hello world'
> 210 |     await browser.elementById('text-input').type(desiredText)
      |     ^
  211 |     expect(await browser.elementById('text-input').getValue()).toBe(desiredText)
  212 | 
  213 |     const currentColor = await browser.eval(

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
  at thenableWebDriverProxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at Object.<anonymous> (integration/scss-modules/test/index.test.js:210:5)

● Valid CSS Module Usage from within node_modules › should have compiled successfully

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  302 | 
  303 |   it('should have compiled successfully', () => {
> 304 |     expect(code).toBe(0)
      |                  ^
  305 |     expect(stdout).toMatch(/Compiled successfully/)
  306 |   })
  307 | 

  at Object.<anonymous> (integration/scss-modules/test/index.test.js:304:18)

● Valid CSS Module Usage from within node_modules › should've prerendered with relevant data

FetchError: request to http://localhost:44885/ failed, reason: connect ECONNREFUSED 127.0.0.1:44885

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Valid CSS Module Usage from within node_modules › should've emitted a single CSS file

ENOENT: no such file or directory, scandir '/home/runner/work/next.js/next.js/test/integration/scss-fixtures/nm-module/.next/static/css'

● Valid Nested CSS Module Usage from within node_modules › should have compiled successfully

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  355 | 
  356 |   it('should have compiled successfully', () => {
> 357 |     expect(code).toBe(0)
      |                  ^
  358 |     expect(stdout).toMatch(/Compiled successfully/)
  359 |   })
  360 | 

  at Object.<anonymous> (integration/scss-modules/test/index.test.js:357:18)

● Valid Nested CSS Module Usage from within node_modules › should've prerendered with relevant data

FetchError: request to http://localhost:35083/ failed, reason: connect ECONNREFUSED 127.0.0.1:35083

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Valid Nested CSS Module Usage from within node_modules › should've emitted a single CSS file

ENOENT: no such file or directory, scandir '/home/runner/work/next.js/next.js/test/integration/scss-fixtures/nm-module-nested/.next/static/css'

● CSS Module Composes Usage (Basic) › should have compiled successfully

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  398 | 
  399 |   it('should have compiled successfully', () => {
> 400 |     expect(code).toBe(0)
      |                  ^
  401 |     expect(stdout).toMatch(/Compiled successfully/)
  402 |   })
  403 | 

  at Object.<anonymous> (integration/scss-modules/test/index.test.js:400:18)

● CSS Module Composes Usage (Basic) › should've emitted a single CSS file

ENOENT: no such file or directory, scandir '/home/runner/work/next.js/next.js/test/integration/scss-fixtures/composes-basic/.next/static/css'

● CSS Module Composes Usage (External) › should have compiled successfully

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  431 | 
  432 |   it('should have compiled successfully', () => {
> 433 |     expect(code).toBe(0)
      |                  ^
  434 |     expect(stdout).toMatch(/Compiled successfully/)
  435 |   })
  436 | 

  at Object.<anonymous> (integration/scss-modules/test/index.test.js:433:18)

● CSS Module Composes Usage (External) › should've emitted a single CSS file

ENOENT: no such file or directory, scandir '/home/runner/work/next.js/next.js/test/integration/scss-fixtures/composes-external/.next/static/css'

● Dynamic Route CSS Module Usage › should have compiled successfully

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  469 | 
  470 |   it('should have compiled successfully', () => {
> 471 |     expect(code).toBe(0)
      |                  ^
  472 |     expect(stdout).toMatch(/Compiled successfully/)
  473 |   })
  474 | 

  at Object.<anonymous> (integration/scss-modules/test/index.test.js:471:18)

● Dynamic Route CSS Module Usage › should've emitted a single CSS file

ENOENT: no such file or directory, scandir '/home/runner/work/next.js/next.js/test/integration/scss-fixtures/dynamic-route-module/.next/static/css'

● Dynamic Route CSS Module Usage › should apply styles correctly

WebDriverError: unknown error: net::ERR_CONNECTION_REFUSED
  (Session info: headless chrome=86.0.4240.183)

  177 |   console.log(`\n> Loading browser with ${url}\n`)
  178 | 
> 179 |   await browser.get(url)
      |   ^
  180 |   console.log(`\n> Loaded browser with ${url}\n`)
  181 | 
  182 |   // Wait for application to hydrate

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
  at thenableWebDriverProxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at _default (lib/next-webdriver.js:179:3)
  at Object.<anonymous> (integration/scss-modules/test/index.test.js:490:21)

● Catch-all Route CSS Module Usage › should have compiled successfully

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  517 | 
  518 |   it('should have compiled successfully', () => {
> 519 |     expect(code).toBe(0)
      |                  ^
  520 |     expect(stdout).toMatch(/Compiled successfully/)
  521 |   })
  522 | 

  at Object.<anonymous> (integration/scss-modules/test/index.test.js:519:18)

● Catch-all Route CSS Module Usage › should apply styles correctly

WebDriverError: unknown error: net::ERR_CONNECTION_REFUSED
  (Session info: headless chrome=86.0.4240.183)

  177 |   console.log(`\n> Loading browser with ${url}\n`)
  178 | 
> 179 |   await browser.get(url)
      |   ^
  180 |   console.log(`\n> Loaded browser with ${url}\n`)
  181 | 
  182 |   // Wait for application to hydrate

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
  at thenableWebDriverProxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at _default (lib/next-webdriver.js:179:3)
  at Object.<anonymous> (integration/scss-modules/test/index.test.js:524:21)

● Catch-all Route CSS Module Usage › should've emitted a single CSS file

ENOENT: no such file or directory, scandir '/home/runner/work/next.js/next.js/test/integration/scss-fixtures/catch-all-module/.next/static/css'

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  275 | export async function killApp(instance) {
  276 |   await new Promise((resolve, reject) => {
> 277 |     treeKill(instance.pid, (err) => {
      |                       ^
  278 |       if (err) {
  279 |         if (
  280 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:277:23
  at killApp (lib/next-test-utils.js:276:9)
  at integration/scss-modules/test/index.test.js:38:11

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  275 | export async function killApp(instance) {
  276 |   await new Promise((resolve, reject) => {
> 277 |     treeKill(instance.pid, (err) => {
      |                       ^
  278 |       if (err) {
  279 |         if (
  280 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:277:23
  at killApp (lib/next-test-utils.js:276:9)
  at integration/scss-modules/test/index.test.js:94:11

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  275 | export async function killApp(instance) {
  276 |   await new Promise((resolve, reject) => {
> 277 |     treeKill(instance.pid, (err) => {
      |                       ^
  278 |       if (err) {
  279 |         if (
  280 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:277:23
  at killApp (lib/next-test-utils.js:276:9)
  at integration/scss-modules/test/index.test.js:174:11

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  275 | export async function killApp(instance) {
  276 |   await new Promise((resolve, reject) => {
> 277 |     treeKill(instance.pid, (err) => {
      |                       ^
  278 |       if (err) {
  279 |         if (
  280 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:277:23
  at killApp (lib/next-test-utils.js:276:9)
  at integration/scss-modules/test/index.test.js:300:11

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  275 | export async function killApp(instance) {
  276 |   await new Promise((resolve, reject) => {
> 277 |     treeKill(instance.pid, (err) => {
      |                       ^
  278 |       if (err) {
  279 |         if (
  280 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:277:23
  at killApp (lib/next-test-utils.js:276:9)
  at integration/scss-modules/test/index.test.js:353:11

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  275 | export async function killApp(instance) {
  276 |   await new Promise((resolve, reject) => {
> 277 |     treeKill(instance.pid, (err) => {
      |                       ^
  278 |       if (err) {
  279 |         if (
  280 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:277:23
  at killApp (lib/next-test-utils.js:276:9)
  at integration/scss-modules/test/index.test.js:468:18

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  275 | export async function killApp(instance) {
  276 |   await new Promise((resolve, reject) => {
> 277 |     treeKill(instance.pid, (err) => {
      |                       ^
  278 |       if (err) {
  279 |         if (
  280 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:277:23
  at killApp (lib/next-test-utils.js:276:9)
  at integration/scss-modules/test/index.test.js:516:18

guybedford · 2020-11-05T22:17:41Z

In the end I needed to revert the Babel work here too since that was initially dependent on the ncc upgrade as well.

Hopefully we can get the ncc upgrade differences worked out shortly to resume these.

ijjk · 2020-11-05T22:28:39Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
buildDuration	14.5s	13.7s	-791ms
nodeModulesSize	87 MB	90 MB	⚠️ +3.03 MB

Page Load Tests Overall increase ✓

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.758	2.643	-0.12
/ avg req/sec	906.39	946.03	+39.64
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.651	1.602	-0.05
/error-in-render avg req/sec	1514.52	1560.08	+45.56

Client Bundles (main, webpack, commons)

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
677f882d2ed8..7d3b.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-7a348ff..641f.js gzip	7.37 kB	7.37 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.4 kB	58.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
677f882d2ed8..dule.js gzip	7.04 kB	7.04 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-00e5ec9..dule.js gzip	6.37 kB	6.37 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-fca3d..2eb1.js gzip	3.44 kB	3.44 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-a674d88..ccde.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-a4469f3..dule.js gzip	1.32 kB	1.32 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.41 kB	5.41 kB	✓

Client Build Manifests Overall increase ⚠️

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_buildManifest.js gzip	321 B	322 B	⚠️ +1 B
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	651 B	652 B	⚠️ +1 B

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	-1 B
withRouter.html gzip	994 B	994 B	✓
Overall change	3 kB	3 kB	-1 B

Diffs

Diff for _buildManifest.js

@@ -2,10 +2,10 @@ self.__BUILD_MANIFEST = {
   __rewrites: [],
   "/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
   "/_error": [
-    "static\u002Fchunks\u002Fpages\u002F_error-9b57cae5694a39479222.js"
+    "static\u002Fchunks\u002Fpages\u002F_error-a0c4519f5ca8e97fa7be.js"
   ],
   "/hooks": [
-    "static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"
+    "static\u002Fchunks\u002Fpages\u002Fhooks-8001dc76075832ee8949.js"
   ],
   "/link": ["static\u002Fchunks\u002Fpages\u002Flink-46fe29f40f6309aec7d7.js"],
   "/routerDirect": [

Diff for index.html

@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.883dd050e11a66b09e26.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -85,7 +85,7 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-f99c1f1d3fffdec91221.js"
+      src="/_next/static/chunks/main-895fe5a26f0416647d53.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
@@ -121,19 +121,19 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.5d4f3798f0f226dab197.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.883dd050e11a66b09e26.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+      src="/_next/static/chunks/pages/_app-7512045a5b3d9376e2ca.js"
       async=""
       crossorigin="anonymous"
       nomodule=""

Diff for link.html

@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.883dd050e11a66b09e26.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -90,7 +90,7 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-f99c1f1d3fffdec91221.js"
+      src="/_next/static/chunks/main-895fe5a26f0416647d53.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
@@ -126,19 +126,19 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.5d4f3798f0f226dab197.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.883dd050e11a66b09e26.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+      src="/_next/static/chunks/pages/_app-7512045a5b3d9376e2ca.js"
       async=""
       crossorigin="anonymous"
       nomodule=""

Diff for withRouter.html

@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.883dd050e11a66b09e26.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -85,7 +85,7 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-f99c1f1d3fffdec91221.js"
+      src="/_next/static/chunks/main-895fe5a26f0416647d53.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
@@ -121,19 +121,19 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.5d4f3798f0f226dab197.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.883dd050e11a66b09e26.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+      src="/_next/static/chunks/pages/_app-7512045a5b3d9376e2ca.js"
       async=""
       crossorigin="anonymous"
       nomodule=""

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
buildDuration	16.3s	15.8s	-531ms
nodeModulesSize	87 MB	90 MB	⚠️ +3.03 MB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
677f882d2ed8..7d3b.js gzip	11.3 kB	N/A	N/A
framework.HASH.js gzip	39 kB	39 kB	✓
main-7a348ff..641f.js gzip	7.37 kB	N/A	N/A
webpack-e067..f178.js gzip	751 B	751 B	✓
677f882d2ed8..02db.js gzip	N/A	11.3 kB	N/A
main-cea8d7e..ff01.js gzip	N/A	7.37 kB	N/A
Overall change	58.4 kB	58.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
677f882d2ed8..dule.js gzip	7.04 kB	N/A	N/A
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-00e5ec9..dule.js gzip	6.37 kB	6.37 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
677f882d2ed8..dule.js gzip	N/A	7.04 kB	N/A
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_app-7231d4b..5856.js gzip	1.28 kB	N/A	N/A
_error-fca3d..2eb1.js gzip	3.44 kB	N/A	N/A
hooks-d4591d..e7c2.js gzip	887 B	N/A	N/A
index-17468f..5d83.js gzip	227 B	227 B	✓
link-a674d88..ccde.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
_app-9a0b9e1..b37e.js gzip	N/A	1.28 kB	N/A
_error-ed1b0..8fbd.js gzip	N/A	3.44 kB	N/A
hooks-89731c..c609.js gzip	N/A	887 B	N/A
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-a4469f3..dule.js gzip	1.32 kB	1.32 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.41 kB	5.41 kB	✓

Client Build Manifests Overall increase ⚠️

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_buildManifest.js gzip	321 B	322 B	⚠️ +1 B
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	651 B	652 B	⚠️ +1 B

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	guybedford/next.js ncc-revert	Change
_error.js	1.07 MB	1.07 MB	⚠️ +21 B
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.07 MB	1.07 MB	⚠️ +21 B
link.js	1.12 MB	1.12 MB	⚠️ +21 B
routerDirect.js	1.11 MB	1.11 MB	⚠️ +21 B
withRouter.js	1.11 MB	1.11 MB	⚠️ +21 B
Overall change	5.49 MB	5.49 MB	⚠️ +105 B

Commit: 89eb734

This reverts commit 4dbb65d.

guybedford requested review from ijjk, lfades, Timer and timneutkens as code owners November 5, 2020 21:35

ijjk added type: next create-next-app Related to our CLI tool for quickly starting a new Next.js application. labels Nov 5, 2020

guybedford added 2 commits November 5, 2020 14:13

yarn dev regression fix, ncc revert

5daaa35

revert babel inlining

89eb734

guybedford force-pushed the ncc-revert branch from 9cae072 to 89eb734 Compare November 5, 2020 22:17

styfle approved these changes Nov 5, 2020

View reviewed changes

ijjk approved these changes Nov 6, 2020

View reviewed changes

kodiakhq bot merged commit 4dbb65d into vercel:canary Nov 6, 2020

guybedford added a commit to guybedford/next.js that referenced this pull request Nov 6, 2020

Revert "yarn dev regression fix, ncc revert (vercel#18861)"

35e7c48

This reverts commit 4dbb65d.

guybedford mentioned this pull request Nov 6, 2020

ncc 0.25.0 upgrade and fixes #18873

Merged

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

yarn dev regression fix, ncc revert #18861

yarn dev regression fix, ncc revert #18861

guybedford commented Nov 5, 2020

ijjk commented Nov 5, 2020

ijjk commented Nov 5, 2020

ijjk commented Nov 5, 2020

guybedford commented Nov 5, 2020

ijjk commented Nov 5, 2020

Diffs

yarn dev regression fix, ncc revert #18861

yarn dev regression fix, ncc revert #18861

Conversation

guybedford commented Nov 5, 2020

ijjk commented Nov 5, 2020

Stats from current PR

ijjk commented Nov 5, 2020

Stats from current PR

ijjk commented Nov 5, 2020

Failing test suites

guybedford commented Nov 5, 2020

ijjk commented Nov 5, 2020

Stats from current PR

Diffs