Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up eventsource initialization #24015

Merged
merged 5 commits into from
Apr 13, 2021
Merged

Clean up eventsource initialization #24015

merged 5 commits into from
Apr 13, 2021

Conversation

timneutkens
Copy link
Member

Just cleans up some code, doesn't change the underlying mechanism

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@timneutkens
Clean up eventsource initialization
48b9e15 
Just cleans up some code, doesn't change the underlying mechanism
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Apr 13, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
buildDuration 14s 13.9s -172ms
nodeModulesSize 46.7 MB 46.7 MB -1 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.381 2.389 ⚠️ +0.01
/ avg req/sec 1049.99 1046.48 ⚠️ -3.51
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.244 1.219 -0.02
/error-in-render avg req/sec 2009.75 2050.79 +41.04
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-6834d41c..48a9.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
index.html gzip 610 B 610 B ✓
link.html gzip 617 B 617 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
buildDuration 17.3s 17.4s ⚠️ +95ms
nodeModulesSize 46.7 MB 46.7 MB -1 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-6834d41c..48a9.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_error.js 1.35 MB 1.35 MB -2 B
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.35 MB 1.35 MB -2 B
link.js 1.4 MB 1.4 MB ✓
routerDirect.js 1.4 MB 1.4 MB ✓
withRouter.js 1.4 MB 1.4 MB ✓
Overall change 6.91 MB 6.91 MB -4 B
Webpack 5 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
buildDuration 14.1s 14.1s -36ms
nodeModulesSize 46.7 MB 46.7 MB -1 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.475 2.464 -0.01
/ avg req/sec 1010.3 1014.75 +4.45
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.268 1.274 ⚠️ +0.01
/error-in-render avg req/sec 1970.89 1961.97 ⚠️ -8.92
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-6834d41c..48a9.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
index.html gzip 610 B 610 B ✓
link.html gzip 617 B 617 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "2mjo7SMc1LPWnLrDQ6yhk",
+        "buildId": "tCxjJXi23JnSCUNkHBcWP",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/2mjo7SMc1LPWnLrDQ6yhk/_buildManifest.js"
+      src="/_next/static/tCxjJXi23JnSCUNkHBcWP/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/2mjo7SMc1LPWnLrDQ6yhk/_ssgManifest.js"
+      src="/_next/static/tCxjJXi23JnSCUNkHBcWP/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "2mjo7SMc1LPWnLrDQ6yhk",
+        "buildId": "tCxjJXi23JnSCUNkHBcWP",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/2mjo7SMc1LPWnLrDQ6yhk/_buildManifest.js"
+      src="/_next/static/tCxjJXi23JnSCUNkHBcWP/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/2mjo7SMc1LPWnLrDQ6yhk/_ssgManifest.js"
+      src="/_next/static/tCxjJXi23JnSCUNkHBcWP/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "2mjo7SMc1LPWnLrDQ6yhk",
+        "buildId": "tCxjJXi23JnSCUNkHBcWP",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/2mjo7SMc1LPWnLrDQ6yhk/_buildManifest.js"
+      src="/_next/static/tCxjJXi23JnSCUNkHBcWP/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/2mjo7SMc1LPWnLrDQ6yhk/_ssgManifest.js"
+      src="/_next/static/tCxjJXi23JnSCUNkHBcWP/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 48b9e15

@ijjk
Copy link
Member

ijjk commented Apr 13, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
buildDuration 14s 13.9s -125ms
nodeModulesSize 46.7 MB 46.7 MB -1.36 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.421 2.438 ⚠️ +0.02
/ avg req/sec 1032.58 1025.6 ⚠️ -6.98
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.217 1.227 ⚠️ +0.01
/error-in-render avg req/sec 2053.39 2036.71 ⚠️ -16.68
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-6834d41c..48a9.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
index.html gzip 610 B 610 B ✓
link.html gzip 617 B 617 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
buildDuration 17.9s 17.4s -425ms
nodeModulesSize 46.7 MB 46.7 MB -1.36 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-6834d41c..48a9.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_error.js 1.35 MB 1.35 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.35 MB 1.35 MB ✓
link.js 1.4 MB 1.4 MB ✓
routerDirect.js 1.4 MB 1.4 MB ✓
withRouter.js 1.4 MB 1.4 MB ✓
Overall change 6.91 MB 6.91 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
buildDuration 14s 14.2s ⚠️ +200ms
nodeModulesSize 46.7 MB 46.7 MB -1.36 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.469 2.49 ⚠️ +0.02
/ avg req/sec 1012.76 1004.17 ⚠️ -8.59
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.254 1.28 ⚠️ +0.03
/error-in-render avg req/sec 1993.28 1952.54 ⚠️ -40.74
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-6834d41c..48a9.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
index.html gzip 610 B 610 B ✓
link.html gzip 617 B 617 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "y2tJ6C4fEuzcgYND8vYeu",
+        "buildId": "3m_-JRjA30p0HSu6qcINq",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/y2tJ6C4fEuzcgYND8vYeu/_buildManifest.js"
+      src="/_next/static/3m_-JRjA30p0HSu6qcINq/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/y2tJ6C4fEuzcgYND8vYeu/_ssgManifest.js"
+      src="/_next/static/3m_-JRjA30p0HSu6qcINq/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "y2tJ6C4fEuzcgYND8vYeu",
+        "buildId": "3m_-JRjA30p0HSu6qcINq",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/y2tJ6C4fEuzcgYND8vYeu/_buildManifest.js"
+      src="/_next/static/3m_-JRjA30p0HSu6qcINq/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/y2tJ6C4fEuzcgYND8vYeu/_ssgManifest.js"
+      src="/_next/static/3m_-JRjA30p0HSu6qcINq/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "y2tJ6C4fEuzcgYND8vYeu",
+        "buildId": "3m_-JRjA30p0HSu6qcINq",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/y2tJ6C4fEuzcgYND8vYeu/_buildManifest.js"
+      src="/_next/static/3m_-JRjA30p0HSu6qcINq/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/y2tJ6C4fEuzcgYND8vYeu/_ssgManifest.js"
+      src="/_next/static/3m_-JRjA30p0HSu6qcINq/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 6cb9eab

@ijjk
Copy link
Member

ijjk commented Apr 13, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
buildDuration 15.9s 16s ⚠️ +169ms
nodeModulesSize 46.9 MB 46.9 MB -1.36 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.885 2.773 -0.11
/ avg req/sec 866.4 901.57 +35.17
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.627 1.588 -0.04
/error-in-render avg req/sec 1536.37 1574.76 +38.39
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-6834d41c..48a9.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
index.html gzip 610 B 610 B ✓
link.html gzip 617 B 617 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
buildDuration 19.9s 19.9s ⚠️ +19ms
nodeModulesSize 46.9 MB 46.9 MB -1.36 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-6834d41c..48a9.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.14 MB 7.14 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
buildDuration 15.8s 15.9s ⚠️ +107ms
nodeModulesSize 46.9 MB 46.9 MB -1.36 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.846 2.838 -0.01
/ avg req/sec 878.37 880.85 +2.48
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.57 1.667 ⚠️ +0.1
/error-in-render avg req/sec 1592.17 1499.31 ⚠️ -92.86
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-6834d41c..48a9.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/cleanup-eventsource Change
index.html gzip 610 B 610 B ✓
link.html gzip 617 B 617 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "d0qk1L3jytzT-aATeRVvo",
+        "buildId": "iWUdWtkuPxbmbX_SpW2rz",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/d0qk1L3jytzT-aATeRVvo/_buildManifest.js"
+      src="/_next/static/iWUdWtkuPxbmbX_SpW2rz/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/d0qk1L3jytzT-aATeRVvo/_ssgManifest.js"
+      src="/_next/static/iWUdWtkuPxbmbX_SpW2rz/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "d0qk1L3jytzT-aATeRVvo",
+        "buildId": "iWUdWtkuPxbmbX_SpW2rz",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/d0qk1L3jytzT-aATeRVvo/_buildManifest.js"
+      src="/_next/static/iWUdWtkuPxbmbX_SpW2rz/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/d0qk1L3jytzT-aATeRVvo/_ssgManifest.js"
+      src="/_next/static/iWUdWtkuPxbmbX_SpW2rz/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "d0qk1L3jytzT-aATeRVvo",
+        "buildId": "iWUdWtkuPxbmbX_SpW2rz",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/d0qk1L3jytzT-aATeRVvo/_buildManifest.js"
+      src="/_next/static/iWUdWtkuPxbmbX_SpW2rz/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/d0qk1L3jytzT-aATeRVvo/_ssgManifest.js"
+      src="/_next/static/iWUdWtkuPxbmbX_SpW2rz/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 43cc48e

@kodiakhq kodiakhq bot merged commit 9baee88 into vercel:canary Apr 13, 2021
@timneutkens timneutkens deleted the fix/cleanup-eventsource branch April 13, 2021 16:50
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@timneutkens @SokratisVidros
Clean up eventsource initialization (vercel#24015)
d6b938d 
Just cleans up some code, doesn't change the underlying mechanism



## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timneutkens @ijjk