Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure locale is not duplicated from differing casing #24187

Merged
merged 2 commits into from
Apr 18, 2021
Merged

Ensure locale is not duplicated from differing casing #24187

merged 2 commits into from
Apr 18, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 17, 2021

This ensures we don't attempt adding a locale to a path when the locale is already present but in a different casing, this also ensures we successfully remove the locale if the casing differs in the path. Additional tests have been added in the i18n-support suites to ensure this is working correctly.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Fixes: #23553

@ijjk
Copy link
Member Author

ijjk commented Apr 17, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
buildDuration 16.7s 16.2s -457ms
buildDurationCached 4.9s 4.9s -22ms
nodeModulesSize 46.2 MB 46.3 MB ⚠️ +715 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.956 2.889 -0.07
/ avg req/sec 845.63 865.42 +19.79
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.702 1.677 -0.02
/error-in-render avg req/sec 1469.2 1490.88 +21.68
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.05 kB 7.05 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
index.html gzip 611 B 609 B -2 B
link.html gzip 616 B 615 B -1 B
withRouter.html gzip 604 B 603 B -1 B
Overall change 1.83 kB 1.83 kB -4 B

Diffs

Diff for 597-HASH.js 
@@ -1436,6 +1436,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
       function addLocale(path, locale, defaultLocale) {
         if (false) {
+          var localeLower, pathLower;
         }
 
         return path;
@@ -1443,7 +1444,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
       function delLocale(path, locale) {
         if (false) {
-          var pathname;
+          var localeLower, pathLower, pathname;
         }
 
         return path;
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-15295a88fc613ba5cbc8.js"
+      href="/_next/static/chunks/webpack-efcad16b0fa0f63cacfc.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-3f45794671bbb399288d.js"
+      href="/_next/static/chunks/597-3d76d013a3fba822863e.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-15295a88fc613ba5cbc8.js"
+      src="/_next/static/chunks/webpack-efcad16b0fa0f63cacfc.js"
       async=""
     ></script>
     <script
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-3f45794671bbb399288d.js"
+      src="/_next/static/chunks/597-3d76d013a3fba822863e.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-15295a88fc613ba5cbc8.js"
+      href="/_next/static/chunks/webpack-efcad16b0fa0f63cacfc.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-3f45794671bbb399288d.js"
+      href="/_next/static/chunks/597-3d76d013a3fba822863e.js"
       as="script"
     />
     <link
@@ -63,7 +63,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-15295a88fc613ba5cbc8.js"
+      src="/_next/static/chunks/webpack-efcad16b0fa0f63cacfc.js"
       async=""
     ></script>
     <script
@@ -71,7 +71,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-3f45794671bbb399288d.js"
+      src="/_next/static/chunks/597-3d76d013a3fba822863e.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-15295a88fc613ba5cbc8.js"
+      href="/_next/static/chunks/webpack-efcad16b0fa0f63cacfc.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-3f45794671bbb399288d.js"
+      href="/_next/static/chunks/597-3d76d013a3fba822863e.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-15295a88fc613ba5cbc8.js"
+      src="/_next/static/chunks/webpack-efcad16b0fa0f63cacfc.js"
       async=""
     ></script>
     <script
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-3f45794671bbb399288d.js"
+      src="/_next/static/chunks/597-3d76d013a3fba822863e.js"
       async=""
     ></script>
     <script
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
buildDuration 20.1s 20.1s ⚠️ +59ms
buildDurationCached 7s 7.3s ⚠️ +313ms
nodeModulesSize 46.2 MB 46.3 MB ⚠️ +715 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.05 kB 7.05 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
_error.js 1.39 MB 1.39 MB ⚠️ +2 B
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.15 MB 7.15 MB ⚠️ +2 B
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
buildDuration 13.1s 13.2s ⚠️ +53ms
buildDurationCached 5.3s 5.3s -73ms
nodeModulesSize 46.2 MB 46.3 MB ⚠️ +715 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.851 2.824 -0.03
/ avg req/sec 876.77 885.2 +8.43
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.614 1.586 -0.03
/error-in-render avg req/sec 1549.39 1576.53 +27.14
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
hooks-HASH.js gzip 888 B 888 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 609 B ⚠️ +2 B
Overall change 1.84 kB 1.84 kB ⚠️ +2 B

Diffs

Diff for 677f882d2ed8..c4df.HASH.js 
@@ -1273,6 +1273,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
       function addLocale(path, locale, defaultLocale) {
         if (false) {
+          var localeLower, pathLower;
         }
 
         return path;
@@ -1280,7 +1281,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
       function delLocale(path, locale) {
         if (false) {
-          var pathname;
+          var localeLower, pathLower, pathname;
         }
 
         return path;
Diff for index.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9435f13b64c68ee0afbc.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0319a78fd6b18e9c7baf.js"
       as="script"
     />
     <link
@@ -61,7 +61,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9435f13b64c68ee0afbc.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0319a78fd6b18e9c7baf.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9435f13b64c68ee0afbc.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0319a78fd6b18e9c7baf.js"
       as="script"
     />
     <link
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9435f13b64c68ee0afbc.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0319a78fd6b18e9c7baf.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9435f13b64c68ee0afbc.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0319a78fd6b18e9c7baf.js"
       as="script"
     />
     <link
@@ -61,7 +61,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9435f13b64c68ee0afbc.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0319a78fd6b18e9c7baf.js"
       async=""
     ></script>
     <script
Commit: 5d78125

@ijjk ijjk marked this pull request as ready for review April 17, 2021 23:33
@ijjk
Copy link
Member Author

ijjk commented Apr 18, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
buildDuration 14.2s 14.3s ⚠️ +54ms
buildDurationCached 4.4s 4.3s -59ms
nodeModulesSize 46.3 MB 46.3 MB ⚠️ +715 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.471 2.488 ⚠️ +0.02
/ avg req/sec 1011.65 1004.79 ⚠️ -6.86
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.266 1.328 ⚠️ +0.06
/error-in-render avg req/sec 1975.05 1882.77 ⚠️ -92.28
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.05 kB 7.05 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
index.html gzip 611 B 609 B -2 B
link.html gzip 616 B 615 B -1 B
withRouter.html gzip 604 B 603 B -1 B
Overall change 1.83 kB 1.83 kB -4 B

Diffs

Diff for 597-HASH.js 
@@ -1436,6 +1436,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
       function addLocale(path, locale, defaultLocale) {
         if (false) {
+          var localeLower, pathLower;
         }
 
         return path;
@@ -1443,7 +1444,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
       function delLocale(path, locale) {
         if (false) {
-          var pathname;
+          var localeLower, pathLower, pathname;
         }
 
         return path;
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-15295a88fc613ba5cbc8.js"
+      href="/_next/static/chunks/webpack-efcad16b0fa0f63cacfc.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-3f45794671bbb399288d.js"
+      href="/_next/static/chunks/597-3d76d013a3fba822863e.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-15295a88fc613ba5cbc8.js"
+      src="/_next/static/chunks/webpack-efcad16b0fa0f63cacfc.js"
       async=""
     ></script>
     <script
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-3f45794671bbb399288d.js"
+      src="/_next/static/chunks/597-3d76d013a3fba822863e.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-15295a88fc613ba5cbc8.js"
+      href="/_next/static/chunks/webpack-efcad16b0fa0f63cacfc.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-3f45794671bbb399288d.js"
+      href="/_next/static/chunks/597-3d76d013a3fba822863e.js"
       as="script"
     />
     <link
@@ -63,7 +63,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-15295a88fc613ba5cbc8.js"
+      src="/_next/static/chunks/webpack-efcad16b0fa0f63cacfc.js"
       async=""
     ></script>
     <script
@@ -71,7 +71,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-3f45794671bbb399288d.js"
+      src="/_next/static/chunks/597-3d76d013a3fba822863e.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-15295a88fc613ba5cbc8.js"
+      href="/_next/static/chunks/webpack-efcad16b0fa0f63cacfc.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-3f45794671bbb399288d.js"
+      href="/_next/static/chunks/597-3d76d013a3fba822863e.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-15295a88fc613ba5cbc8.js"
+      src="/_next/static/chunks/webpack-efcad16b0fa0f63cacfc.js"
       async=""
     ></script>
     <script
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-3f45794671bbb399288d.js"
+      src="/_next/static/chunks/597-3d76d013a3fba822863e.js"
       async=""
     ></script>
     <script
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
buildDuration 17.7s 17.7s -51ms
buildDurationCached 6.6s 6.5s -146ms
nodeModulesSize 46.3 MB 46.3 MB ⚠️ +715 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.05 kB 7.05 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB -2 B
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.15 MB 7.15 MB -2 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
buildDuration 12.3s 12.2s -105ms
buildDurationCached 4.8s 4.8s -89ms
nodeModulesSize 46.3 MB 46.3 MB ⚠️ +715 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.399 2.448 ⚠️ +0.05
/ avg req/sec 1042.04 1021.15 ⚠️ -20.89
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.247 1.262 ⚠️ +0.01
/error-in-render avg req/sec 2004.44 1980.21 ⚠️ -24.23
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
hooks-HASH.js gzip 888 B 888 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-locale-casing Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 609 B ⚠️ +2 B
Overall change 1.84 kB 1.84 kB ⚠️ +2 B

Diffs

Diff for 677f882d2ed8..c4df.HASH.js 
@@ -1273,6 +1273,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
       function addLocale(path, locale, defaultLocale) {
         if (false) {
+          var localeLower, pathLower;
         }
 
         return path;
@@ -1280,7 +1281,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
       function delLocale(path, locale) {
         if (false) {
-          var pathname;
+          var localeLower, pathLower, pathname;
         }
 
         return path;
Diff for index.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9435f13b64c68ee0afbc.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0319a78fd6b18e9c7baf.js"
       as="script"
     />
     <link
@@ -61,7 +61,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9435f13b64c68ee0afbc.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0319a78fd6b18e9c7baf.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9435f13b64c68ee0afbc.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0319a78fd6b18e9c7baf.js"
       as="script"
     />
     <link
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9435f13b64c68ee0afbc.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0319a78fd6b18e9c7baf.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9435f13b64c68ee0afbc.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0319a78fd6b18e9c7baf.js"
       as="script"
     />
     <link
@@ -61,7 +61,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9435f13b64c68ee0afbc.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0319a78fd6b18e9c7baf.js"
       async=""
     ></script>
     <script
Commit: f39c187

@kodiakhq kodiakhq bot merged commit a153b63 into vercel:canary Apr 18, 2021
@ijjk ijjk deleted the fix/i18n-locale-casing branch April 18, 2021 12:00
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@ijjk @SokratisVidros
Ensure locale is not duplicated from differing casing (vercel#24187)
a64fe08 
This ensures we don't attempt adding a locale to a path when the locale is already present but in a different casing, this also ensures we successfully remove the locale if the casing differs in the path. Additional tests have been added in the `i18n-support` suites to ensure this is working correctly. 

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added

Fixes: vercel#23553
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regional Locale duplicate route on back button pressed
2 participants
@ijjk @timneutkens