Add event for webpack 5 usage #24222

timneutkens · 2021-04-19T13:54:15Z

Bug

Related issues linked using fixes #number
Integration tests added

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

Make sure the linting passes

ijjk · 2021-04-19T14:47:12Z

Failing test suites

Commit: 7436d3e

test/integration/amphtml/test/index.test.js

AMP Usage > AMP dev mode > should detect changes and refresh an AMP page
AMP Usage > AMP dev mode > should not reload unless the page is edited for an AMP page

Expand output

● AMP Usage › AMP dev mode › should detect changes and refresh an AMP page

expect(received).toBe(expected) // Object.is equality

Expected: "I'm an AMP page!"
Received: "replaced it!"

  361 |         browser = await webdriver(dynamicAppPort, '/hmr/amp')
  362 |         const text = await browser.elementByCss('p').text()
> 363 |         expect(text).toBe(`I'm an AMP page!`)
      |                      ^
  364 |
  365 |         const hmrTestPagePath = join(__dirname, '../', 'pages', 'hmr', 'amp.js')
  366 |

  at Object.<anonymous> (integration/amphtml/test/index.test.js:363:22)

● AMP Usage › AMP dev mode › should not reload unless the page is edited for an AMP page

TIMED OUT: /I'm an AMP page!/

replaced it!

  393 |
  394 |   if (hardError) {
> 395 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  396 |   }
  397 |   return false
  398 | }

  at check (lib/next-test-utils.js:395:11)
  at Object.<anonymous> (integration/amphtml/test/index.test.js:409:9)

ijjk · 2021-04-19T14:48:06Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
buildDuration	16.3s	16.2s	-15ms
buildDurationCached	4.9s	4.9s	⚠️ +56ms
nodeModulesSize	46.3 MB	46.3 MB	⚠️ +698 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.933	2.911	-0.02
/ avg req/sec	852.29	858.91	+6.62
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.653	1.661	⚠️ +0.01
/error-in-render avg req/sec	1512.58	1505.55	⚠️ -7.03

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
597-HASH.js gzip	13.3 kB	13.3 kB	✓
778-HASH.js gzip	7.08 kB	7.08 kB	✓
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_app-HASH.js gzip	1.3 kB	1.3 kB	✓
_error-HASH.js gzip	3.68 kB	3.68 kB	✓
amp-HASH.js gzip	558 B	558 B	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	243 B	243 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	336 B	336 B	✓
withRouter-HASH.js gzip	334 B	334 B	✓
Overall change	9.03 kB	9.03 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_buildManifest.js gzip	349 B	349 B	✓
Overall change	349 B	349 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
index.html gzip	609 B	609 B	✓
link.html gzip	614 B	614 B	✓
withRouter.html gzip	604 B	604 B	✓
Overall change	1.83 kB	1.83 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
buildDuration	20.5s	20.4s	-60ms
buildDurationCached	7.2s	7.2s	⚠️ +48ms
nodeModulesSize	46.3 MB	46.3 MB	⚠️ +698 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
597-HASH.js gzip	13.3 kB	13.3 kB	✓
778-HASH.js gzip	7.08 kB	7.08 kB	✓
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_app-HASH.js gzip	1.3 kB	1.3 kB	✓
_error-HASH.js gzip	3.68 kB	3.68 kB	✓
amp-HASH.js gzip	558 B	558 B	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	243 B	243 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	336 B	336 B	✓
withRouter-HASH.js gzip	334 B	334 B	✓
Overall change	9.03 kB	9.03 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_buildManifest.js gzip	349 B	349 B	✓
Overall change	349 B	349 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_error.js	1.39 MB	1.39 MB	✓
404.html	2.76 kB	2.76 kB	✓
500.html	2.75 kB	2.75 kB	✓
amp.amp.html	10.7 kB	10.7 kB	✓
amp.html	1.96 kB	1.96 kB	✓
hooks.html	2.01 kB	2.01 kB	✓
index.js	1.39 MB	1.39 MB	✓
link.js	1.45 MB	1.45 MB	✓
routerDirect.js	1.44 MB	1.44 MB	✓
withRouter.js	1.44 MB	1.44 MB	✓
Overall change	7.15 MB	7.15 MB	✓

Webpack 4 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
buildDuration	13.6s	14s	⚠️ +389ms
buildDurationCached	5.5s	5.5s	-36ms
nodeModulesSize	46.3 MB	46.3 MB	⚠️ +698 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.901	2.909	⚠️ +0.01
/ avg req/sec	861.83	859.26	⚠️ -2.57
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.656	1.632	-0.02
/error-in-render avg req/sec	1510.09	1532.21	+22.12

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
677f882d2ed8..HASH.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.16 kB	7.16 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	60.2 kB	60.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_app-HASH.js gzip	1.28 kB	1.28 kB	✓
_error-HASH.js gzip	3.71 kB	3.71 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
hooks-HASH.js gzip	888 B	888 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
Overall change	8.89 kB	8.89 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_buildManifest.js gzip	371 B	371 B	✓
Overall change	371 B	371 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
index.html gzip	613 B	613 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Commit: 7436d3e

ijjk · 2021-04-19T15:00:20Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
buildDuration	14.7s	14.8s	⚠️ +66ms
buildDurationCached	4.5s	4.6s	⚠️ +71ms
nodeModulesSize	46.3 MB	46.3 MB	⚠️ +698 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.734	2.693	-0.04
/ avg req/sec	914.49	928.24	+13.75
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.55	1.573	⚠️ +0.02
/error-in-render avg req/sec	1612.54	1588.9	⚠️ -23.64

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
597-HASH.js gzip	13.3 kB	13.3 kB	✓
778-HASH.js gzip	7.08 kB	7.08 kB	✓
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_app-HASH.js gzip	1.3 kB	1.3 kB	✓
_error-HASH.js gzip	3.68 kB	3.68 kB	✓
amp-HASH.js gzip	558 B	558 B	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	243 B	243 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	336 B	336 B	✓
withRouter-HASH.js gzip	334 B	334 B	✓
Overall change	9.03 kB	9.03 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_buildManifest.js gzip	349 B	349 B	✓
Overall change	349 B	349 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
index.html gzip	609 B	609 B	✓
link.html gzip	614 B	614 B	✓
withRouter.html gzip	604 B	604 B	✓
Overall change	1.83 kB	1.83 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
buildDuration	18.6s	18s	-605ms
buildDurationCached	6.4s	6.3s	-48ms
nodeModulesSize	46.3 MB	46.3 MB	⚠️ +698 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
597-HASH.js gzip	13.3 kB	13.3 kB	✓
778-HASH.js gzip	7.08 kB	7.08 kB	✓
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_app-HASH.js gzip	1.3 kB	1.3 kB	✓
_error-HASH.js gzip	3.68 kB	3.68 kB	✓
amp-HASH.js gzip	558 B	558 B	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	243 B	243 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	336 B	336 B	✓
withRouter-HASH.js gzip	334 B	334 B	✓
Overall change	9.03 kB	9.03 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_buildManifest.js gzip	349 B	349 B	✓
Overall change	349 B	349 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_error.js	1.39 MB	1.39 MB	✓
404.html	2.76 kB	2.76 kB	✓
500.html	2.75 kB	2.75 kB	✓
amp.amp.html	10.7 kB	10.7 kB	✓
amp.html	1.96 kB	1.96 kB	✓
hooks.html	2.01 kB	2.01 kB	✓
index.js	1.39 MB	1.39 MB	✓
link.js	1.45 MB	1.45 MB	⚠️ +2 B
routerDirect.js	1.44 MB	1.44 MB	✓
withRouter.js	1.44 MB	1.44 MB	-2 B
Overall change	7.15 MB	7.15 MB	✓

Webpack 4 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
buildDuration	12.2s	12.2s	-81ms
buildDurationCached	4.9s	5s	⚠️ +47ms
nodeModulesSize	46.3 MB	46.3 MB	⚠️ +698 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.617	2.607	-0.01
/ avg req/sec	955.37	958.91	+3.54
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.481	1.487	⚠️ +0.01
/error-in-render avg req/sec	1688.43	1681.41	⚠️ -7.02

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
677f882d2ed8..HASH.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.16 kB	7.16 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	60.2 kB	60.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_app-HASH.js gzip	1.28 kB	1.28 kB	✓
_error-HASH.js gzip	3.71 kB	3.71 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
hooks-HASH.js gzip	888 B	888 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
Overall change	8.89 kB	8.89 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_buildManifest.js gzip	371 B	371 B	✓
Overall change	371 B	371 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
index.html gzip	613 B	613 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Commit: 04e4907

packages/next/server/next-dev-server.ts

ijjk · 2021-04-19T18:23:09Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
buildDuration	16s	16.2s	⚠️ +139ms
buildDurationCached	5.4s	4.8s	-538ms
nodeModulesSize	46.3 MB	46.3 MB	⚠️ +997 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.886	2.924	⚠️ +0.04
/ avg req/sec	866.17	855.06	⚠️ -11.11
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.655	1.656	0
/error-in-render avg req/sec	1510.53	1509.65	⚠️ -0.88

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
597-HASH.js gzip	13.3 kB	13.3 kB	✓
778-HASH.js gzip	7.08 kB	7.08 kB	✓
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_app-HASH.js gzip	1.3 kB	1.3 kB	✓
_error-HASH.js gzip	3.68 kB	3.68 kB	✓
amp-HASH.js gzip	558 B	558 B	✓
css-HASH.js gzip	363 B	363 B	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	243 B	243 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	336 B	336 B	✓
withRouter-HASH.js gzip	334 B	334 B	✓
Overall change	9.4 kB	9.4 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
index.html gzip	610 B	610 B	✓
link.html gzip	616 B	616 B	✓
withRouter.html gzip	605 B	605 B	✓
Overall change	1.83 kB	1.83 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
buildDuration	20.4s	20.6s	⚠️ +188ms
buildDurationCached	7.7s	7.6s	-121ms
nodeModulesSize	46.3 MB	46.3 MB	⚠️ +997 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
597-HASH.js gzip	13.3 kB	13.3 kB	✓
778-HASH.js gzip	7.08 kB	7.08 kB	✓
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_app-HASH.js gzip	1.3 kB	1.3 kB	✓
_error-HASH.js gzip	3.68 kB	3.68 kB	✓
amp-HASH.js gzip	558 B	558 B	✓
css-HASH.js gzip	363 B	363 B	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	243 B	243 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	336 B	336 B	✓
withRouter-HASH.js gzip	334 B	334 B	✓
Overall change	9.4 kB	9.4 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_error.js	1.39 MB	1.39 MB	✓
404.html	2.76 kB	2.76 kB	✓
500.html	2.75 kB	2.75 kB	✓
amp.amp.html	10.7 kB	10.7 kB	✓
amp.html	1.96 kB	1.96 kB	✓
css.html	2.13 kB	2.13 kB	✓
hooks.html	2.01 kB	2.01 kB	✓
index.js	1.39 MB	1.39 MB	✓
link.js	1.45 MB	1.45 MB	✓
routerDirect.js	1.44 MB	1.44 MB	⚠️ +2 B
withRouter.js	1.44 MB	1.44 MB	-2 B
Overall change	7.15 MB	7.15 MB	✓

Webpack 4 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
buildDuration	13.4s	13.8s	⚠️ +380ms
buildDurationCached	5.7s	5.5s	-219ms
nodeModulesSize	46.3 MB	46.3 MB	⚠️ +997 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.815	2.803	-0.01
/ avg req/sec	888.15	891.88	+3.73
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.707	1.734	⚠️ +0.03
/error-in-render avg req/sec	1464.69	1441.67	⚠️ -23.02

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
677f882d2ed8..HASH.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.16 kB	7.16 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	60.2 kB	60.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_app-HASH.js gzip	1.28 kB	1.28 kB	✓
_error-HASH.js gzip	3.71 kB	3.71 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
Overall change	9.23 kB	9.23 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
_buildManifest.js gzip	419 B	419 B	✓
Overall change	419 B	419 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add-webpack5-event	Change
index.html gzip	612 B	612 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	606 B	606 B	✓
Overall change	1.84 kB	1.84 kB	✓

Commit: 06e86ee

Add event for webpack 5 usage

e5e9d24

timneutkens requested review from divmain, ijjk, lfades and shuding as code owners April 19, 2021 13:54

ijjk added the type: next label Apr 19, 2021

Name event webpackVersion

cb61ed8

sokra previously approved these changes Apr 19, 2021

View reviewed changes

Update other event params

7436d3e

timneutkens dismissed sokra’s stale review via 7436d3e April 19, 2021 14:34

Merge branch 'canary' into add-webpack5-event

04e4907

Timer reviewed Apr 19, 2021

View reviewed changes

packages/next/server/next-dev-server.ts Outdated Show resolved Hide resolved

Add webpackVersion to dev server

06e86ee

timneutkens merged commit 8d84b08 into vercel:canary Apr 20, 2021

timneutkens deleted the add-webpack5-event branch April 20, 2021 14:46

SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021

Add event for webpack 5 usage (vercel#24222)

6f22535

sync-by-unito bot mentioned this pull request May 18, 2021

chore(deps): bump next from 10.0.7 to 10.2.0 filecoin-project/slate#736

Closed

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add event for webpack 5 usage #24222

Add event for webpack 5 usage #24222

timneutkens commented Apr 19, 2021

ijjk commented Apr 19, 2021

ijjk commented Apr 19, 2021

ijjk commented Apr 19, 2021

ijjk commented Apr 19, 2021

Add event for webpack 5 usage #24222

Add event for webpack 5 usage #24222

Conversation

timneutkens commented Apr 19, 2021

Bug

Feature

Documentation / Examples

ijjk commented Apr 19, 2021

Failing test suites

ijjk commented Apr 19, 2021

Stats from current PR

ijjk commented Apr 19, 2021

Stats from current PR

ijjk commented Apr 19, 2021

Stats from current PR