-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump styled-components lib version examples #24482
Merged
kodiakhq
merged 5 commits into
vercel:canary
from
omariosouto:UPDATE-STYLED-COMPONENTS-LIB-VERSIONS
Apr 27, 2021
Merged
feat: bump styled-components lib version examples #24482
kodiakhq
merged 5 commits into
vercel:canary
from
omariosouto:UPDATE-STYLED-COMPONENTS-LIB-VERSIONS
Apr 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omariosouto
requested review from
divmain,
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
April 26, 2021 22:36
leerob
reviewed
Apr 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is react-is
needed?
@leerob I just follow the FAQ from the migration guide: https://styled-components.com/docs/faqs#what-do-i-need-to-do-to-migrate-to-v5 In a project that I've been working on it was necessary and already was present in other examples |
leerob
reviewed
Apr 27, 2021
omariosouto
commented
Apr 27, 2021
omariosouto
commented
Apr 27, 2021
leerob
approved these changes
Apr 27, 2021
ijjk
approved these changes
Apr 27, 2021
This was referenced Apr 28, 2021
This was referenced Apr 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks I know many people that use that example and it could be using the new version of React to be according with the NextJS v11
Documentation / Examples