Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable optimized loading strategy #26021

Merged
merged 3 commits into from
Jun 12, 2021
Merged

Enable optimized loading strategy #26021

merged 3 commits into from
Jun 12, 2021

Conversation

janicklas-ralph
Copy link
Contributor

Enable optimized Loading strategy by default

@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Jun 11, 2021

Failing test suites

Commit: 37cc737

test/integration/relay-analytics/test/index.test.js

  • Analytics relayer > Relays the data to user code
Expand output

● Analytics relayer › Relays the data to user code

expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

@@ -3,7 +3,7 @@
    "event_name": "FCP",
    "href": StringMatching /http:\/\//,
    "id": StringContaining "-",
    "page": "/",
    "speed": "4g",
-   "value": StringContaining ".",
+   "value": "51",
  }

  67 |
  68 |     expect(beacons.length).toBe(2)
> 69 |     expect(beacons[0]).toMatchObject({
     |                        ^
  70 |       dsn: 'test',
  71 |       event_name: 'FCP',
  72 |       href: expect.stringMatching('http://'),

  at Object.<anonymous> (integration/relay-analytics/test/index.test.js:69:24)

@ijjk
Copy link
Member

ijjk commented Jun 11, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary janicklas-ralph/next.js preload Change
buildDuration 10.9s 11s ⚠️ +130ms
buildDurationCached 2.6s 2.7s ⚠️ +25ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +281 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary janicklas-ralph/next.js preload Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.235 2.142 -0.09
/ avg req/sec 1118.7 1167.01 +48.31
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.118 1.155 ⚠️ +0.04
/error-in-render avg req/sec 2235.17 2164.39 ⚠️ -70.78
Client Bundles (main, webpack, commons)
vercel/next.js canary janicklas-ralph/next.js preload Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary janicklas-ralph/next.js preload Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary janicklas-ralph/next.js preload Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.18 kB 3.18 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.43 kB 8.43 kB ✓
Client Build Manifests
vercel/next.js canary janicklas-ralph/next.js preload Change
_buildManifest.js gzip 395 B 395 B ✓
Overall change 395 B 395 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary janicklas-ralph/next.js preload Change
index.html gzip 573 B 521 B -52 B
link.html gzip 581 B 535 B -46 B
withRouter.html gzip 567 B 516 B -51 B
Overall change 1.72 kB 1.57 kB -149 B

Diffs

Diff for index.html 
@@ -5,70 +5,46 @@
     <meta name="viewport" content="width=device-width" />
     <meta name="next-head-count" content="2" />
     <noscript data-n-css=""></noscript>
-    <link
-      rel="preload"
-      href="/_next/static/chunks/webpack-16fb5e52861014c05b14.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/framework-9501ba6381d32c7692e1.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/main-8faa48d5cdf3a72b0a3c.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/pages/_app-28769756f9a0c21b149b.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/pages/index-96d821e908dd023681e4.js"
-      as="script"
-    />
-  </head>
-  <body>
-    <div id="__next">Hello world 👋</div>
-    <script id="__NEXT_DATA__" type="application/json">
-      {
-        "props": { "pageProps": {} },
-        "page": "/",
-        "query": {},
-        "buildId": "BUILD_ID",
-        "isFallback": false,
-        "gip": true,
-        "scriptLoader": []
-      }
-    </script>
     <script
+      defer=""
       nomodule=""
       src="/_next/static/chunks/polyfills-78af6fe89161f65f5762.js"
     ></script>
     <script
       src="/_next/static/chunks/webpack-16fb5e52861014c05b14.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/framework-9501ba6381d32c7692e1.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/main-8faa48d5cdf3a72b0a3c.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/pages/_app-28769756f9a0c21b149b.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/pages/index-96d821e908dd023681e4.js"
-      async=""
+      defer=""
     ></script>
-    <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""></script>
-    <script src="/_next/static/BUILD_ID/_ssgManifest.js" async=""></script>
+    <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
+    <script src="/_next/static/BUILD_ID/_ssgManifest.js" defer=""></script>
+  </head>
+  <body>
+    <div id="__next">Hello world 👋</div>
+    <script id="__NEXT_DATA__" type="application/json">
+      {
+        "props": { "pageProps": {} },
+        "page": "/",
+        "query": {},
+        "buildId": "BUILD_ID",
+        "isFallback": false,
+        "gip": true,
+        "scriptLoader": []
+      }
+    </script>
   </body>
 </html>
Diff for link.html 
@@ -5,75 +5,51 @@
     <meta name="viewport" content="width=device-width" />
     <meta name="next-head-count" content="2" />
     <noscript data-n-css=""></noscript>
-    <link
-      rel="preload"
-      href="/_next/static/chunks/webpack-16fb5e52861014c05b14.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/framework-9501ba6381d32c7692e1.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/main-8faa48d5cdf3a72b0a3c.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/pages/_app-28769756f9a0c21b149b.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/pages/link-59cf3226dc2ef2788890.js"
-      as="script"
-    />
-  </head>
-  <body>
-    <div id="__next">
-      <div>
-        <h3>A Link page!</h3>
-        <a href="/">Go to /</a>
-      </div>
-    </div>
-    <script id="__NEXT_DATA__" type="application/json">
-      {
-        "props": { "pageProps": {} },
-        "page": "/link",
-        "query": {},
-        "buildId": "BUILD_ID",
-        "isFallback": false,
-        "gip": true,
-        "scriptLoader": []
-      }
-    </script>
     <script
+      defer=""
       nomodule=""
       src="/_next/static/chunks/polyfills-78af6fe89161f65f5762.js"
     ></script>
     <script
       src="/_next/static/chunks/webpack-16fb5e52861014c05b14.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/framework-9501ba6381d32c7692e1.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/main-8faa48d5cdf3a72b0a3c.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/pages/_app-28769756f9a0c21b149b.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/pages/link-59cf3226dc2ef2788890.js"
-      async=""
+      defer=""
     ></script>
-    <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""></script>
-    <script src="/_next/static/BUILD_ID/_ssgManifest.js" async=""></script>
+    <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
+    <script src="/_next/static/BUILD_ID/_ssgManifest.js" defer=""></script>
+  </head>
+  <body>
+    <div id="__next">
+      <div>
+        <h3>A Link page!</h3>
+        <a href="/">Go to /</a>
+      </div>
+    </div>
+    <script id="__NEXT_DATA__" type="application/json">
+      {
+        "props": { "pageProps": {} },
+        "page": "/link",
+        "query": {},
+        "buildId": "BUILD_ID",
+        "isFallback": false,
+        "gip": true,
+        "scriptLoader": []
+      }
+    </script>
   </body>
 </html>
Diff for withRouter.html 
@@ -5,70 +5,46 @@
     <meta name="viewport" content="width=device-width" />
     <meta name="next-head-count" content="2" />
     <noscript data-n-css=""></noscript>
-    <link
-      rel="preload"
-      href="/_next/static/chunks/webpack-16fb5e52861014c05b14.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/framework-9501ba6381d32c7692e1.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/main-8faa48d5cdf3a72b0a3c.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/pages/_app-28769756f9a0c21b149b.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/pages/withRouter-452d126a75584c6a354e.js"
-      as="script"
-    />
-  </head>
-  <body>
-    <div id="__next"><div>I use withRouter</div></div>
-    <script id="__NEXT_DATA__" type="application/json">
-      {
-        "props": { "pageProps": {} },
-        "page": "/withRouter",
-        "query": {},
-        "buildId": "BUILD_ID",
-        "isFallback": false,
-        "gip": true,
-        "scriptLoader": []
-      }
-    </script>
     <script
+      defer=""
       nomodule=""
       src="/_next/static/chunks/polyfills-78af6fe89161f65f5762.js"
     ></script>
     <script
       src="/_next/static/chunks/webpack-16fb5e52861014c05b14.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/framework-9501ba6381d32c7692e1.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/main-8faa48d5cdf3a72b0a3c.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/pages/_app-28769756f9a0c21b149b.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/pages/withRouter-452d126a75584c6a354e.js"
-      async=""
+      defer=""
     ></script>
-    <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""></script>
-    <script src="/_next/static/BUILD_ID/_ssgManifest.js" async=""></script>
+    <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
+    <script src="/_next/static/BUILD_ID/_ssgManifest.js" defer=""></script>
+  </head>
+  <body>
+    <div id="__next"><div>I use withRouter</div></div>
+    <script id="__NEXT_DATA__" type="application/json">
+      {
+        "props": { "pageProps": {} },
+        "page": "/withRouter",
+        "query": {},
+        "buildId": "BUILD_ID",
+        "isFallback": false,
+        "gip": true,
+        "scriptLoader": []
+      }
+    </script>
   </body>
 </html>
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary janicklas-ralph/next.js preload Change
buildDuration 12s 12.4s ⚠️ +398ms
buildDurationCached 3.7s 3.5s -230ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +281 B
Client Bundles (main, webpack, commons)
vercel/next.js canary janicklas-ralph/next.js preload Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary janicklas-ralph/next.js preload Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary janicklas-ralph/next.js preload Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.18 kB 3.18 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.43 kB 8.43 kB ✓
Client Build Manifests
vercel/next.js canary janicklas-ralph/next.js preload Change
_buildManifest.js gzip 395 B 395 B ✓
Overall change 395 B 395 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary janicklas-ralph/next.js preload Change
_error.js 16.9 kB 16.9 kB -2 B
404.html 2.44 kB 1.98 kB -463 B
500.html 2.43 kB 1.96 kB -463 B
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.63 kB 1.17 kB -460 B
css.html 1.81 kB 1.35 kB -460 B
hooks.html 1.69 kB 1.23 kB -462 B
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ⚠️ +2 B
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 105 kB -2.31 kB
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary janicklas-ralph/next.js preload Change
buildDuration 9.2s 9.8s ⚠️ +596ms
buildDurationCached 4.1s 3.7s -352ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +281 B
Page Load Tests Overall increase ✓
vercel/next.js canary janicklas-ralph/next.js preload Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.065 1.929 -0.14
/ avg req/sec 1210.84 1296.01 +85.17
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.199 1.025 -0.17
/error-in-render avg req/sec 2085.19 2439.56 +354.37
Client Bundles (main, webpack, commons)
vercel/next.js canary janicklas-ralph/next.js preload Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 61.1 kB 61.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary janicklas-ralph/next.js preload Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary janicklas-ralph/next.js preload Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.85 kB 3.85 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.28 kB 9.28 kB ✓
Client Build Manifests
vercel/next.js canary janicklas-ralph/next.js preload Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary janicklas-ralph/next.js preload Change
index.html gzip 627 B 568 B -59 B
link.html gzip 633 B 581 B -52 B
withRouter.html gzip 620 B 560 B -60 B
Overall change 1.88 kB 1.71 kB -171 B

Diffs

Diff for index.html 
@@ -5,79 +5,50 @@
     <meta name="viewport" content="width=device-width" />
     <meta name="next-head-count" content="2" />
     <noscript data-n-css=""></noscript>
-    <link
-      rel="preload"
-      href="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.20a22da5dd60e15fb078.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/main-2905608690234b155906.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/pages/_app-14e4eac7b0cda2ea09bf.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/pages/index-b460df3d63326fbb06a1.js"
-      as="script"
-    />
-  </head>
-  <body>
-    <div id="__next">Hello world 👋</div>
-    <script id="__NEXT_DATA__" type="application/json">
-      {
-        "props": { "pageProps": {} },
-        "page": "/",
-        "query": {},
-        "buildId": "BUILD_ID",
-        "isFallback": false,
-        "gip": true,
-        "scriptLoader": []
-      }
-    </script>
     <script
+      defer=""
       nomodule=""
       src="/_next/static/chunks/polyfills-8e6ada07653aff5607ec.js"
     ></script>
     <script
       src="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.20a22da5dd60e15fb078.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/main-2905608690234b155906.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/pages/_app-14e4eac7b0cda2ea09bf.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/pages/index-b460df3d63326fbb06a1.js"
-      async=""
+      defer=""
     ></script>
-    <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""></script>
-    <script src="/_next/static/BUILD_ID/_ssgManifest.js" async=""></script>
+    <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
+    <script src="/_next/static/BUILD_ID/_ssgManifest.js" defer=""></script>
+  </head>
+  <body>
+    <div id="__next">Hello world 👋</div>
+    <script id="__NEXT_DATA__" type="application/json">
+      {
+        "props": { "pageProps": {} },
+        "page": "/",
+        "query": {},
+        "buildId": "BUILD_ID",
+        "isFallback": false,
+        "gip": true,
+        "scriptLoader": []
+      }
+    </script>
   </body>
 </html>
Diff for link.html 
@@ -5,84 +5,55 @@
     <meta name="viewport" content="width=device-width" />
     <meta name="next-head-count" content="2" />
     <noscript data-n-css=""></noscript>
-    <link
-      rel="preload"
-      href="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.20a22da5dd60e15fb078.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/main-2905608690234b155906.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/pages/_app-14e4eac7b0cda2ea09bf.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/pages/link-670e2914a4b319eea5ad.js"
-      as="script"
-    />
-  </head>
-  <body>
-    <div id="__next">
-      <div>
-        <h3>A Link page!</h3>
-        <a href="/">Go to /</a>
-      </div>
-    </div>
-    <script id="__NEXT_DATA__" type="application/json">
-      {
-        "props": { "pageProps": {} },
-        "page": "/link",
-        "query": {},
-        "buildId": "BUILD_ID",
-        "isFallback": false,
-        "gip": true,
-        "scriptLoader": []
-      }
-    </script>
     <script
+      defer=""
       nomodule=""
       src="/_next/static/chunks/polyfills-8e6ada07653aff5607ec.js"
     ></script>
     <script
       src="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.20a22da5dd60e15fb078.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/main-2905608690234b155906.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/pages/_app-14e4eac7b0cda2ea09bf.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/pages/link-670e2914a4b319eea5ad.js"
-      async=""
+      defer=""
     ></script>
-    <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""></script>
-    <script src="/_next/static/BUILD_ID/_ssgManifest.js" async=""></script>
+    <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
+    <script src="/_next/static/BUILD_ID/_ssgManifest.js" defer=""></script>
+  </head>
+  <body>
+    <div id="__next">
+      <div>
+        <h3>A Link page!</h3>
+        <a href="/">Go to /</a>
+      </div>
+    </div>
+    <script id="__NEXT_DATA__" type="application/json">
+      {
+        "props": { "pageProps": {} },
+        "page": "/link",
+        "query": {},
+        "buildId": "BUILD_ID",
+        "isFallback": false,
+        "gip": true,
+        "scriptLoader": []
+      }
+    </script>
   </body>
 </html>
Diff for withRouter.html 
@@ -5,79 +5,50 @@
     <meta name="viewport" content="width=device-width" />
     <meta name="next-head-count" content="2" />
     <noscript data-n-css=""></noscript>
-    <link
-      rel="preload"
-      href="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.20a22da5dd60e15fb078.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/main-2905608690234b155906.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/pages/_app-14e4eac7b0cda2ea09bf.js"
-      as="script"
-    />
-    <link
-      rel="preload"
-      href="/_next/static/chunks/pages/withRouter-c910fe66863aa0ee6cad.js"
-      as="script"
-    />
-  </head>
-  <body>
-    <div id="__next"><div>I use withRouter</div></div>
-    <script id="__NEXT_DATA__" type="application/json">
-      {
-        "props": { "pageProps": {} },
-        "page": "/withRouter",
-        "query": {},
-        "buildId": "BUILD_ID",
-        "isFallback": false,
-        "gip": true,
-        "scriptLoader": []
-      }
-    </script>
     <script
+      defer=""
       nomodule=""
       src="/_next/static/chunks/polyfills-8e6ada07653aff5607ec.js"
     ></script>
     <script
       src="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.20a22da5dd60e15fb078.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/main-2905608690234b155906.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/pages/_app-14e4eac7b0cda2ea09bf.js"
-      async=""
+      defer=""
     ></script>
     <script
       src="/_next/static/chunks/pages/withRouter-c910fe66863aa0ee6cad.js"
-      async=""
+      defer=""
     ></script>
-    <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""></script>
-    <script src="/_next/static/BUILD_ID/_ssgManifest.js" async=""></script>
+    <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
+    <script src="/_next/static/BUILD_ID/_ssgManifest.js" defer=""></script>
+  </head>
+  <body>
+    <div id="__next"><div>I use withRouter</div></div>
+    <script id="__NEXT_DATA__" type="application/json">
+      {
+        "props": { "pageProps": {} },
+        "page": "/withRouter",
+        "query": {},
+        "buildId": "BUILD_ID",
+        "isFallback": false,
+        "gip": true,
+        "scriptLoader": []
+      }
+    </script>
   </body>
 </html>
Commit: ee2d3f2

@kodiakhq kodiakhq bot merged commit 66d1d53 into vercel:canary Jun 12, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@janicklas-ralph
Enable optimized loading strategy (vercel#26021)
c9212c4 
Enable optimized Loading strategy by default
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janicklas-ralph @ijjk @timneutkens