Fix `next/script` unhandled promise rejection #27903

janicklas-ralph · 2021-08-09T22:26:28Z

Bug

fixes next/script creates unhandled promise rejection with empty error for every script that fails to load #27747
Integration tests added

test/integration/script-loader/pages/page3.js

ijjk · 2021-08-10T17:14:20Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	janicklas-ralph/next.js script	Change
buildDuration	18.2s	17.8s	-315ms
buildDurationCached	4s	4s	⚠️ +5ms
nodeModulesSize	49.1 MB	49.1 MB	⚠️ +165 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	janicklas-ralph/next.js script	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.344	3.398	⚠️ +0.05
/ avg req/sec	747.7	735.67	⚠️ -12.03
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.112	2.081	-0.03
/error-in-render avg req/sec	1183.71	1201.39	+17.68

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	janicklas-ralph/next.js script	Change
745.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	23.1 kB	23.1 kB	⚠️ +6 B
webpack-HASH.js gzip	1.5 kB	1.5 kB	✓
Overall change	67 kB	67 kB	⚠️ +6 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js script	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	janicklas-ralph/next.js script	Change
_app-HASH.js gzip	980 B	980 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	329 B	329 B	✓
dynamic-HASH.js gzip	2.52 kB	2.52 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	904 B	904 B	✓
image-HASH.js gzip	4.12 kB	4.12 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	319 B	319 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	12.8 kB	12.8 kB	✓

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js script	Change
_buildManifest.js gzip	490 B	490 B	✓
Overall change	490 B	490 B	✓

Rendered Page Sizes

	vercel/next.js canary	janicklas-ralph/next.js script	Change
index.html gzip	532 B	531 B	-1 B
link.html gzip	543 B	544 B	⚠️ +1 B
withRouter.html gzip	523 B	523 B	✓
Overall change	1.6 kB	1.6 kB	✓

Diffs

Diff for main-HASH.js

@@ -3250,20 +3250,20 @@
 
         var el = document.createElement("script");
         var loadPromise = new Promise(function(resolve, reject) {
-          el.addEventListener("load", function() {
+          el.addEventListener("load", function(e) {
             resolve();
 
             if (onLoad) {
-              onLoad.call(this);
+              onLoad.call(this, e);
             }
           });
-          el.addEventListener("error", function() {
-            reject();
-
-            if (onError) {
-              onError();
-            }
+          el.addEventListener("error", function(e) {
+            reject(e);
           });
+        })["catch"](function(e) {
+          if (onError) {
+            onError(e);
+          }
         });
 
         if (src) {

Diff for index.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-93972797ff4e7b271197.js"
+      src="/_next/static/chunks/main-bfac2c856fac944512ab.js"
       defer=""
     ></script>
     <script

Diff for link.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-93972797ff4e7b271197.js"
+      src="/_next/static/chunks/main-bfac2c856fac944512ab.js"
       defer=""
     ></script>
     <script

Diff for withRouter.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-93972797ff4e7b271197.js"
+      src="/_next/static/chunks/main-bfac2c856fac944512ab.js"
       defer=""
     ></script>
     <script

Webpack 4 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	janicklas-ralph/next.js script	Change
buildDuration	14.8s	15s	⚠️ +243ms
buildDurationCached	5.8s	5.7s	-126ms
nodeModulesSize	49.1 MB	49.1 MB	⚠️ +165 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	janicklas-ralph/next.js script	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.237	3.253	⚠️ +0.02
/ avg req/sec	772.33	768.57	⚠️ -3.76
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.08	2.057	-0.02
/error-in-render avg req/sec	1201.95	1215.11	+13.16

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	janicklas-ralph/next.js script	Change
17.HASH.js gzip	185 B	185 B	✓
677f882d2ed8..HASH.js gzip	14 kB	14 kB	✓
framework.HASH.js gzip	41.9 kB	41.9 kB	✓
main-HASH.js gzip	10.6 kB	10.6 kB	⚠️ +3 B
webpack-HASH.js gzip	1.19 kB	1.19 kB	✓
Overall change	67.8 kB	67.9 kB	⚠️ +3 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js script	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages Overall increase ⚠️

	vercel/next.js canary	janicklas-ralph/next.js script	Change
_app-HASH.js gzip	965 B	965 B	✓
_error-HASH.js gzip	3.71 kB	3.71 kB	✓
amp-HASH.js gzip	552 B	552 B	✓
css-HASH.js gzip	333 B	333 B	✓
dynamic-HASH.js gzip	2.71 kB	2.71 kB	✓
head-HASH.js gzip	2.97 kB	2.97 kB	✓
hooks-HASH.js gzip	911 B	911 B	✓
index-HASH.js gzip	231 B	231 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	298 B	298 B	✓
script-HASH.js gzip	2.94 kB	2.95 kB	⚠️ +9 B
withRouter-HASH.js gzip	294 B	294 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	17.7 kB	17.7 kB	⚠️ +9 B

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js script	Change
_buildManifest.js gzip	498 B	498 B	✓
Overall change	498 B	498 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	janicklas-ralph/next.js script	Change
index.html gzip	577 B	577 B	✓
link.html gzip	590 B	589 B	-1 B
withRouter.html gzip	570 B	570 B	✓
Overall change	1.74 kB	1.74 kB	-1 B

Diffs

Diff for _buildManifest.js

@@ -21,7 +21,7 @@ self.__BUILD_MANIFEST = {
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-6969fe7df87ea0f513b7.js"
   ],
   "/script": [
-    "static\u002Fchunks\u002Fpages\u002Fscript-72fdd0aacc5133678fb0.js"
+    "static\u002Fchunks\u002Fpages\u002Fscript-4f37d5d753427e16b66e.js"
   ],
   "/withRouter": [
     "static\u002Fchunks\u002Fpages\u002FwithRouter-d324ed0c40e148c2c3fc.js"

Diff for script-HASH.js

@@ -166,20 +166,20 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
 
         var el = document.createElement("script");
         var loadPromise = new Promise(function(resolve, reject) {
-          el.addEventListener("load", function() {
+          el.addEventListener("load", function(e) {
             resolve();
 
             if (onLoad) {
-              onLoad.call(this);
+              onLoad.call(this, e);
             }
           });
-          el.addEventListener("error", function() {
-            reject();
-
-            if (onError) {
-              onError();
-            }
+          el.addEventListener("error", function(e) {
+            reject(e);
           });
+        })["catch"](function(e) {
+          if (onError) {
+            onError(e);
+          }
         });
 
         if (src) {

Diff for main-HASH.js

@@ -748,20 +748,20 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
 
         var el = document.createElement("script");
         var loadPromise = new Promise(function(resolve, reject) {
-          el.addEventListener("load", function() {
+          el.addEventListener("load", function(e) {
             resolve();
 
             if (onLoad) {
-              onLoad.call(this);
+              onLoad.call(this, e);
             }
           });
-          el.addEventListener("error", function() {
-            reject();
-
-            if (onError) {
-              onError();
-            }
+          el.addEventListener("error", function(e) {
+            reject(e);
           });
+        })["catch"](function(e) {
+          if (onError) {
+            onError(e);
+          }
         });
 
         if (src) {

Diff for index.html

@@ -23,7 +23,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-12dc0b93eed90c767139.js"
+      src="/_next/static/chunks/main-a81f837869d1a2a9b638.js"
       defer=""
     ></script>
     <script

Diff for link.html

@@ -23,7 +23,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-12dc0b93eed90c767139.js"
+      src="/_next/static/chunks/main-a81f837869d1a2a9b638.js"
       defer=""
     ></script>
     <script

Diff for withRouter.html

@@ -23,7 +23,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-12dc0b93eed90c767139.js"
+      src="/_next/static/chunks/main-a81f837869d1a2a9b638.js"
       defer=""
     ></script>
     <script

Commit: 1c77210

## Bug - [x] fixes vercel#27747 - [x] Integration tests added

Fix vercel#27747

5491d12

janicklas-ralph requested review from huozhi, ijjk, padmaia, shuding, styfle and timneutkens as code owners August 9, 2021 22:26

ijjk added created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next labels Aug 9, 2021

styfle requested a review from housseindjirdeh August 9, 2021 22:27

styfle reviewed Aug 9, 2021

View reviewed changes

test/integration/script-loader/pages/page3.js Outdated Show resolved Hide resolved

styfle changed the title ~~Fix #27747~~ Fix next/script unhandled promise rejection Aug 9, 2021

housseindjirdeh previously approved these changes Aug 10, 2021

View reviewed changes

Fix lint error

0e5fab1

janicklas-ralph dismissed housseindjirdeh’s stale review via 0e5fab1 August 10, 2021 17:00

Merge branch 'canary' of github.com:vercel/next.js into script

1c77210

ijjk approved these changes Aug 10, 2021

View reviewed changes

kodiakhq bot merged commit 43393d5 into vercel:canary Aug 10, 2021

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021

Fix next/script unhandled promise rejection (vercel#27903)

ff1109b

## Bug - [x] fixes vercel#27747 - [x] Integration tests added

ijjk mentioned this pull request Sep 21, 2021

uncaught (in promise) undefined using next/script, google analytics. #27609

Closed

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `next/script` unhandled promise rejection #27903

Fix `next/script` unhandled promise rejection #27903

janicklas-ralph commented Aug 9, 2021

ijjk commented Aug 10, 2021

Diffs

Diffs

Fix next/script unhandled promise rejection #27903

Fix next/script unhandled promise rejection #27903

Conversation

janicklas-ralph commented Aug 9, 2021

Bug

ijjk commented Aug 10, 2021

Stats from current PR

Diffs

Diffs

Fix `next/script` unhandled promise rejection #27903

Fix `next/script` unhandled promise rejection #27903