Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe solution to centralized routing #2844

Merged
merged 4 commits into from
Aug 28, 2017
Merged

Conversation

ldthorne
Copy link
Contributor

Add a section to the README with a solution to the issue surrounding separated routing that arises when using Next.js' static export for a site.

Adding per #2823.

cc @timneutkens

@timneutkens
Copy link
Member

Hey @ldthorne I'm thinking we'd best add this to the wiki here: https://github.com/zeit/next.js/wiki and then link to it from the readme. Since it's not a super common use case 👌

@ldthorne
Copy link
Contributor Author

Ah gotcha @timneutkens. Just added the solution to the wiki and linked to it from the FAQ in the Static Export section in the README. Let me know what you think!

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ❤️ Thanks!

@timneutkens
Copy link
Member

@arunoda can you merge this?

@arunoda
Copy link
Contributor

arunoda commented Aug 28, 2017

Looks fine for me.

@arunoda arunoda merged commit d227617 into vercel:master Aug 28, 2017
@ldthorne ldthorne deleted the update-readme branch August 28, 2017 22:55
@lock lock bot locked as resolved and limited conversation to collaborators Aug 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants