Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(examples/with-next-translate) Removed Redundancies in Strings #29501

Merged
merged 4 commits into from
Jan 5, 2022
Merged

(examples/with-next-translate) Removed Redundancies in Strings #29501

merged 4 commits into from
Jan 5, 2022

Conversation

brookton
Copy link
Contributor

with-next-translate Example Refactor

  • Linting passes

Purpose for changes

  • The existing locals folder is using a redundant string structure which continuously repeats "Change language to " in separate instances in separate languages alongside separate language translations.
  • This PR is a simple refactor to extract "change language to" to it's own string, and references already existing strings defining the language translation.

Why they might be helpful

  • A user looking to implement this pattern should consider reducing redundancies as early as possible to scale an app, thus I believe it would be helpful for this example.

Notes:

  • these original translations were done via google translate
  • verified that these strings still make sense and translate properly in every locale / language
  • these strings are meant to be examples, translations have not been verified with a translation agency.

@ijjk ijjk added the examples Issue was opened via the examples template. label Sep 29, 2021
@brookton brookton changed the title Removed redundancies in strings (Example/with-next-translate) Removed Redundancies in Strings Sep 29, 2021
@brookton brookton changed the title (Example/with-next-translate) Removed Redundancies in Strings (examples/with-next-translate) Removed Redundancies in Strings Sep 29, 2021
@ijjk ijjk requested a review from steven-tey as a code owner January 5, 2022 18:07
ijjk added 2 commits January 5, 2022 12:15
…rookton/next.js into refactor/example/translations-brookton
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq bot merged commit 2efc944 into vercel:canary Jan 5, 2022
@vercel vercel locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants