Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/rust workflow #30577

Merged
merged 27 commits into from
Oct 29, 2021
Merged

Chore/rust workflow #30577

merged 27 commits into from
Oct 29, 2021

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Oct 28, 2021

Updated the Rust workflow to use most recent canaries instead of checked in binaries. CI now uses a quick dev build.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 28, 2021
@padmaia padmaia force-pushed the chore/rust-workflow branch from d1c7094 to 12aa210 Compare October 28, 2021 20:59
@padmaia padmaia force-pushed the chore/rust-workflow branch from 12aa210 to 7cfae6c Compare October 28, 2021 21:13
@padmaia padmaia marked this pull request as ready for review October 28, 2021 21:26
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to update to include the native folder in the files of the package.json for Next.js when running create-next-install for our tests that package/install Next.js

@padmaia
Copy link
Member Author

padmaia commented Oct 28, 2021

@ijjk That should already be happening here https://github.com/vercel/next.js/blob/canary/.github/actions/next-stats-action/src/prepare/repo-setup.js#L102

@padmaia
Copy link
Member Author

padmaia commented Oct 28, 2021

It might just be a bad path in downloading the artifact, let me try something.

@padmaia padmaia force-pushed the chore/rust-workflow branch 5 times, most recently from 248c810 to 938e806 Compare October 28, 2021 23:06
This was referenced Nov 1, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants