Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dev option for the middleware SSR loader #30639

Merged
merged 6 commits into from
Oct 30, 2021

Conversation

shuding
Copy link
Member

@shuding shuding commented Oct 29, 2021

Currently the dev option isn't passed to the render function inside the middleware SSR loader. This PR fixes it with a test case.

Fixes #30547.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

huozhi
huozhi previously approved these changes Oct 29, 2021
ijjk
ijjk previously approved these changes Oct 29, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@shuding shuding dismissed stale reviews from ijjk and huozhi via fc84bf8 October 29, 2021 23:14
@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Oct 29, 2021
@ijjk

This comment has been minimized.

@shuding shuding requested review from ijjk and huozhi October 30, 2021 00:15
@ijjk
Copy link
Member

ijjk commented Oct 30, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/8488 Change
buildDuration 24s 23.6s -389ms
buildDurationCached 5.1s 4.9s -180ms
nodeModulesSize 294 MB 294 MB ⚠️ +55 B
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/8488 Change
/ failed reqs 0 0
/ total time (seconds) 3.911 3.848 -0.06
/ avg req/sec 639.26 649.66 +10.4
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.042 2.025 -0.02
/error-in-render avg req/sec 1224.35 1234.39 +10.04
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/8488 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/8488 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/8488 Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/8488 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/8488 Change
index.html gzip 534 B 534 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/8488 Change
buildDuration 25.4s 25.6s ⚠️ +197ms
buildDurationCached 5.1s 4.9s -179ms
nodeModulesSize 294 MB 294 MB ⚠️ +55 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/8488 Change
/ failed reqs 0 0
/ total time (seconds) 3.853 3.948 ⚠️ +0.09
/ avg req/sec 648.87 633.17 ⚠️ -15.7
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.044 2.083 ⚠️ +0.04
/error-in-render avg req/sec 1223.24 1200.18 ⚠️ -23.06
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/8488 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/8488 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/8488 Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/8488 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/8488 Change
index.html gzip 535 B 535 B
link.html gzip 548 B 548 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB
Commit: cea89bf

@kodiakhq kodiakhq bot merged commit 48874f1 into vercel:canary Oct 30, 2021
@shuding shuding deleted the shu/8488 branch October 30, 2021 09:20
This was referenced Nov 1, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global styles with concurrent mode
4 participants