-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-commonjs and update swc #30661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
requested review from
huozhi,
ijjk,
padmaia,
shuding,
styfle and
timneutkens
as code owners
October 30, 2021 10:58
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Failing test suitesCommit: f7c9438 test/integration/preload-viewport/test/index.test.js
Expand output● Prefetching Links in viewport › should not prefetch already loaded scripts
|
timneutkens
approved these changes
Oct 30, 2021
This was referenced Nov 1, 2021
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
Closes vercel#30596 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint` - This patch contains several patches from swc. This includes swc-project/swc#2581, which allows customizing the import path for regenerator. - This adds auto-detection of common js. If `module.exports` is found and module config is not set, module config becomes common js. - As bonus, this includes some performance improvements The logic for analyzing the input source file and parsing options as json is moved from the js thread to a background worker thread.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30596
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples
Make sure the linting passes by running
yarn lint
This patch contains several patches from swc.
This includes swc-project/swc#2581, which allows customizing the import path for regenerator.
If
module.exports
is found and module config is not set, module config becomes common js.The logic for analyzing the input source file and parsing options as json is moved from the js thread to a background worker thread.