Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getStaticProps override exportPathMap #31906

Conversation

MaedahBatool
Copy link
Contributor

Added a note about getStaticProps overriding any configuration with exportPathMap in docs.

Feature

@MaedahBatool MaedahBatool marked this pull request as draft November 29, 2021 07:13
@MaedahBatool MaedahBatool marked this pull request as ready for review November 29, 2021 07:13
@ijjk
Copy link
Member

ijjk commented Nov 29, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary MaedahBatool/next.js staticprops-overrides-exportpathmap Change
buildDuration 19.3s 19.3s ⚠️ +55ms
buildDurationCached 3.6s 3.8s ⚠️ +189ms
nodeModulesSize 346 MB 346 MB -1 B
Page Load Tests Overall increase ✓
vercel/next.js canary MaedahBatool/next.js staticprops-overrides-exportpathmap Change
/ failed reqs 0 0
/ total time (seconds) 3.186 3.177 -0.01
/ avg req/sec 784.72 786.92 +2.2
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.497 1.439 -0.06
/error-in-render avg req/sec 1670.28 1736.74 +66.46
Client Bundles (main, webpack, commons)
vercel/next.js canary MaedahBatool/next.js staticprops-overrides-exportpathmap Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary MaedahBatool/next.js staticprops-overrides-exportpathmap Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary MaedahBatool/next.js staticprops-overrides-exportpathmap Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.45 kB 4.45 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary MaedahBatool/next.js staticprops-overrides-exportpathmap Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary MaedahBatool/next.js staticprops-overrides-exportpathmap Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary MaedahBatool/next.js staticprops-overrides-exportpathmap Change
buildDuration 20.5s 20.8s ⚠️ +281ms
buildDurationCached 3.6s 3.7s ⚠️ +58ms
nodeModulesSize 346 MB 346 MB -1 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary MaedahBatool/next.js staticprops-overrides-exportpathmap Change
/ failed reqs 0 0
/ total time (seconds) 3.181 3.154 -0.03
/ avg req/sec 785.99 792.73 +6.74
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.423 1.438 ⚠️ +0.01
/error-in-render avg req/sec 1756.46 1738.49 ⚠️ -17.97
Client Bundles (main, webpack, commons)
vercel/next.js canary MaedahBatool/next.js staticprops-overrides-exportpathmap Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary MaedahBatool/next.js staticprops-overrides-exportpathmap Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary MaedahBatool/next.js staticprops-overrides-exportpathmap Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.47 kB 4.47 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary MaedahBatool/next.js staticprops-overrides-exportpathmap Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary MaedahBatool/next.js staticprops-overrides-exportpathmap Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: a0f0afa

@@ -19884,7 +19884,7 @@ watchpack-chokidar2@^2.0.0:
dependencies:
chokidar "^2.1.8"

watchpack@2.3.0, watchpack@^2.2.0, watchpack@^2.3.0:
watchpack@2.3.0, watchpack@^2.3.0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert these changes? 😄

@MaedahBatool MaedahBatool changed the title 📦 NEW: Add getStaticProps override exportPathMap Add getStaticProps override exportPathMap Dec 1, 2021
Co-authored-by: Rich Haines <hello@richardhaines.dev>
@molebox
Copy link
Collaborator

molebox commented Dec 17, 2021

This was completed in another PR #31465 closing

@molebox molebox closed this Dec 17, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants