Example: Externals - config for untranspiled external packages #3732
Conversation
ghengeveld
changed the title
| }) | ||
| config.module.rules.push({ | ||
| test: /\.+(js|jsx)$/, | ||
| loader: defaultLoaders.babel, |
There was a problem hiding this comment.
Does this respect my local babel config? Trying this out but wouldn't process stage-2.
There was a problem hiding this comment.
Yep defaultLoaders.babel is provided by next to be integrated into plugins / next.config.js. It's the same babel config used to configure .js transpilation 🙏
There was a problem hiding this comment.
A fully working example will help a lot
There was a problem hiding this comment.
I can say that this next.config.js does indeed work. I took what's here and tested in my own project (Lerna based).
| const webpack = require("webpack") | ||
|
|
||
| // Update these to match your package scope name. | ||
| const internalNodeModulesRegExp = /@zeit(?!.*node_modules)/ |
There was a problem hiding this comment.
A little confused by how this works. The internalNodeModulesRegExp won't replace the scan to our internal node_modules right?
And what's the externalNodeModules? seems like it's used to ignore a re-compile in webpackDevServer?
|
Whats remaining on blocking this merge? Happy to help. |
|
Does this work with |
| @@ -0,0 +1,26 @@ | |||
| const webpack = require("webpack") | |||
There was a problem hiding this comment.
Why is webpack imported here? Is this needed?
|
Going to close this in favor of https://github.com/zeit/next.js/blob/canary/examples/with-yarn-workspaces/packages/web-app/next.config.js |
|
@timneutkens I am the maintainer of |
|
@martpie |
|
Thank you for noticing that, I'll have a look |
This provides an example
next.config.jswhich adds support for external untranspiled npm packages. It overrides Webpack'sexternalsso it will process these packages and configures webpack-dev-server to enable HMR onnpm linked local packages.