-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add upgrade guide for Middleware. #37382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and concise! I left some comments as I read along
Post back to #29750 once merged! |
Co-authored-by: Rich Haines <hello@richardhaines.dev> Co-authored-by: Edward Thomson <ethomson@github.com> Co-authored-by: Dominik Ferber <dominik.ferber@gmail.com>
Co-authored-by: Rich Haines <hello@richardhaines.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should fix my previous comment and add a before and after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool collective work!
🎉
Co-authored-by: Damien Simonin Feugas <damien.feugas@gmail.com>
Co-authored-by: Rich Haines <hello@richardhaines.dev>
Co-authored-by: Rich Haines <hello@richardhaines.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the new user agent helper upgrade section
Co-authored-by: Rich Haines <hello@richardhaines.dev>
* Middleware upgrade guide * Add a bit more * Apply suggestions from code review Co-authored-by: Rich Haines <hello@richardhaines.dev> Co-authored-by: Edward Thomson <ethomson@github.com> Co-authored-by: Dominik Ferber <dominik.ferber@gmail.com> * Apply suggestions from code review Co-authored-by: Rich Haines <hello@richardhaines.dev> * Updates based on PR comments * Add before / after * Flip paragraphs * Apply suggestions from code review Co-authored-by: Rich Haines <hello@richardhaines.dev> * Apply suggestions from code review Co-authored-by: Kiko Beats <josefrancisco.verdu@gmail.com> * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Damien Simonin Feugas <damien.feugas@gmail.com> * Update errors/middleware-upgrade-guide.md Co-authored-by: Dom Sip <dominik.sipowicz@gmail.com> * Update errors/middleware-upgrade-guide.md Co-authored-by: Damien Simonin Feugas <damien.feugas@gmail.com> * Update middleware-upgrade-guide.md * Update errors/middleware-upgrade-guide.md Co-authored-by: Rich Haines <hello@richardhaines.dev> * Update errors/middleware-upgrade-guide.md Co-authored-by: Rich Haines <hello@richardhaines.dev> * Apply suggestions from code review Co-authored-by: Rich Haines <hello@richardhaines.dev> * Apply suggestions from code review * Update errors/middleware-upgrade-guide.md Co-authored-by: Rich Haines <hello@richardhaines.dev> Co-authored-by: Edward Thomson <ethomson@github.com> Co-authored-by: Dominik Ferber <dominik.ferber@gmail.com> Co-authored-by: Kiko Beats <josefrancisco.verdu@gmail.com> Co-authored-by: Damien Simonin Feugas <damien.feugas@gmail.com> Co-authored-by: Dom Sip <dominik.sipowicz@gmail.com>
This adds an upgrade guide for folks who have been using Middleware while in beta, to allow them to use the latest APIs. These changes have been made based on customer feedback, so thank you for those who have been early adopters of Middleware.