Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade guide for Middleware. #37382

Merged
merged 23 commits into from
Jun 16, 2022
Merged

Add upgrade guide for Middleware. #37382

merged 23 commits into from
Jun 16, 2022

Conversation

leerob
Copy link
Member

@leerob leerob commented Jun 1, 2022

This adds an upgrade guide for folks who have been using Middleware while in beta, to allow them to use the latest APIs. These changes have been made based on customer feedback, so thank you for those who have been early adopters of Middleware.

Copy link
Contributor

@dferber90 dferber90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and concise! I left some comments as I read along

errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
@leerob
Copy link
Member Author

leerob commented Jun 2, 2022

Post back to #29750 once merged!

Co-authored-by: Rich Haines <hello@richardhaines.dev>
Co-authored-by: Edward Thomson <ethomson@github.com>
Co-authored-by: Dominik Ferber <dominik.ferber@gmail.com>
leerob and others added 2 commits June 2, 2022 10:27
Co-authored-by: Rich Haines <hello@richardhaines.dev>
Copy link
Collaborator

@molebox molebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix my previous comment and add a before and after

errors/middleware-upgrade-guide.md Show resolved Hide resolved
@leerob leerob marked this pull request as ready for review June 2, 2022 18:41
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
feugy
feugy previously approved these changes Jun 7, 2022
Copy link
Member

@feugy feugy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool collective work!
🎉

errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Show resolved Hide resolved
Co-authored-by: Damien Simonin Feugas <damien.feugas@gmail.com>
@leerob leerob dismissed stale reviews from feugy and timeyoutakeit via 8d69811 June 8, 2022 22:01
leerob and others added 3 commits June 8, 2022 17:04
Co-authored-by: Rich Haines <hello@richardhaines.dev>
Co-authored-by: Rich Haines <hello@richardhaines.dev>
Copy link
Collaborator

@molebox molebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the new user agent helper upgrade section

errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
Co-authored-by: Rich Haines <hello@richardhaines.dev>
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
errors/middleware-upgrade-guide.md Outdated Show resolved Hide resolved
cramforce
cramforce previously approved these changes Jun 15, 2022
@cramforce cramforce merged commit eb55af1 into canary Jun 16, 2022
@cramforce cramforce deleted the middleware-upgrade-guide branch June 16, 2022 16:29
aboqasem pushed a commit to aboqasem/next.js that referenced this pull request Jun 18, 2022
* Middleware upgrade guide

* Add a bit more

* Apply suggestions from code review

Co-authored-by: Rich Haines <hello@richardhaines.dev>
Co-authored-by: Edward Thomson <ethomson@github.com>
Co-authored-by: Dominik Ferber <dominik.ferber@gmail.com>

* Apply suggestions from code review

Co-authored-by: Rich Haines <hello@richardhaines.dev>

* Updates based on PR comments

* Add before / after

* Flip paragraphs

* Apply suggestions from code review

Co-authored-by: Rich Haines <hello@richardhaines.dev>

* Apply suggestions from code review

Co-authored-by: Kiko Beats <josefrancisco.verdu@gmail.com>

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Damien Simonin Feugas <damien.feugas@gmail.com>

* Update errors/middleware-upgrade-guide.md

Co-authored-by: Dom Sip <dominik.sipowicz@gmail.com>

* Update errors/middleware-upgrade-guide.md

Co-authored-by: Damien Simonin Feugas <damien.feugas@gmail.com>

* Update middleware-upgrade-guide.md

* Update errors/middleware-upgrade-guide.md

Co-authored-by: Rich Haines <hello@richardhaines.dev>

* Update errors/middleware-upgrade-guide.md

Co-authored-by: Rich Haines <hello@richardhaines.dev>

* Apply suggestions from code review

Co-authored-by: Rich Haines <hello@richardhaines.dev>

* Apply suggestions from code review

* Update errors/middleware-upgrade-guide.md

Co-authored-by: Rich Haines <hello@richardhaines.dev>
Co-authored-by: Edward Thomson <ethomson@github.com>
Co-authored-by: Dominik Ferber <dominik.ferber@gmail.com>
Co-authored-by: Kiko Beats <josefrancisco.verdu@gmail.com>
Co-authored-by: Damien Simonin Feugas <damien.feugas@gmail.com>
Co-authored-by: Dom Sip <dominik.sipowicz@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.