Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Webpack 4 #4108

Closed
wants to merge 3 commits into from
Closed

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Apr 4, 2018

Don't merge

Lets try to get next/router to function properly first before moving on to adding chunks etc.

Code that doesn't use next/link / next/router runs fine.

@timneutkens timneutkens changed the title [WIP] Initial webpack 4, without chunks, with broken router [WIP] Webpack 4 Apr 4, 2018
@timneutkens
Copy link
Member Author

Added a vendor chunk, holding react-dom and react + next.js specific files like the router, also in dev. But it didn't solve the singleton router issue.

@rashidul0405
Copy link
Contributor

@timneutkens for vendor chunks, can we expose a settings override - may be an entry on next.config.js? sensible defaults with override feature?

@timneutkens
Copy link
Member Author

@rashidul0405 I don't understand what you're asking 🤔. You can just use the webpack function to extend the webpack config.

@rashidul0405
Copy link
Contributor

rashidul0405 commented Apr 11, 2018

@timneutkens Talking about this one: facebook/create-react-app#2206. In order to achieve this, for the current implementation, we will need to override whole splitChunks settings?

@rashidul0405
Copy link
Contributor

just ability to pass which modules should end up into vendor.js chunk.

@simonjoom
Copy link

simonjoom commented May 11, 2018

singleton router resolved here:
and Full working HMR with hot reload (no router update or reload)
see ;
#4332

@rashidul0405
Copy link
Contributor

@timneutkens please ignore my comments, I was checking server bundles and commented based on that. client side bundles are fine for now (all node_modules to main.js).

@timneutkens timneutkens deleted the feature/webpack4 branch July 24, 2018 09:19
@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants