-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test navigation between multiple root layouts #43762
Merged
timneutkens
merged 18 commits into
canary
from
jankaifer/nex-96-add-test-for-multiple-root-layouts
Jan 5, 2023
Merged
Test navigation between multiple root layouts #43762
timneutkens
merged 18 commits into
canary
from
jankaifer/nex-96-add-test-for-multiple-root-layouts
Jan 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankaifer
requested review from
timneutkens,
ijjk,
shuding and
huozhi
as code owners
December 6, 2022 12:33
jankaifer
commented
Dec 7, 2022
jankaifer
commented
Dec 7, 2022
Stats from current PRDefault Build (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size Overall increase
|
vercel/next.js canary | vercel/next.js jankaifer/nex-96-add-test-for-multiple-root-layouts | Change | |
---|---|---|---|
edge-ssr.js gzip | 110 kB | 110 kB | ✓ |
page.js gzip | 98.4 kB | 98.4 kB | |
Overall change | 209 kB | 209 kB |
Middleware size Overall decrease ✓
vercel/next.js canary | vercel/next.js jankaifer/nex-96-add-test-for-multiple-root-layouts | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 582 B | 581 B | -1 B |
middleware-r..fest.js gzip | 145 B | 145 B | ✓ |
middleware.js gzip | 27 kB | 27 kB | ✓ |
edge-runtime..pack.js gzip | 1.83 kB | 1.83 kB | ✓ |
Overall change | 29.6 kB | 29.6 kB | -1 B |
Diffs
Diff for page.js
@@ -8618,7 +8618,7 @@ Learn More: https://nextjs.org/docs/messages/node-module-in-edge-runtime`;
/***/
},
- /***/ 6738: /***/ (
+ /***/ 1036: /***/ (
__unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
@@ -8627,10 +8627,10 @@ Learn More: https://nextjs.org/docs/messages/node-module-in-edge-runtime`;
__webpack_require__.bind(__webpack_require__, 1210)
);
Promise.resolve(/* import() eager */).then(
- __webpack_require__.bind(__webpack_require__, 6448)
+ __webpack_require__.bind(__webpack_require__, 2973)
);
Promise.resolve(/* import() eager */).then(
- __webpack_require__.bind(__webpack_require__, 2973)
+ __webpack_require__.bind(__webpack_require__, 6448)
);
Promise.resolve(/* import() eager */).then(
__webpack_require__.bind(__webpack_require__, 9916)
Diff for middleware-b..-manifest.js
@@ -9,7 +9,7 @@ self.__BUILD_MANIFEST = {
rootMainFiles: [
"static/chunks/webpack-c452a3e31b73f504.js",
"static/chunks/152-792c0b16c9234019.js",
- "static/chunks/main-app-41573aefc84f5f2e.js"
+ "static/chunks/main-app-c9a0aaff35eafcb5.js"
],
pages: {
"/": [
Diff for main-app-HASH.js
@@ -1,7 +1,7 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[744],
{
- /***/ 2938: /***/ function(
+ /***/ 9915: /***/ function(
__unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
@@ -10,10 +10,10 @@
__webpack_require__.t.bind(__webpack_require__, 429, 23)
);
Promise.resolve(/* import() eager */).then(
- __webpack_require__.t.bind(__webpack_require__, 8138, 23)
+ __webpack_require__.t.bind(__webpack_require__, 1161, 23)
);
Promise.resolve(/* import() eager */).then(
- __webpack_require__.t.bind(__webpack_require__, 1161, 23)
+ __webpack_require__.t.bind(__webpack_require__, 8138, 23)
);
Promise.resolve(/* import() eager */).then(
__webpack_require__.t.bind(__webpack_require__, 9379, 23)
@@ -28,7 +28,7 @@
return __webpack_require__((__webpack_require__.s = moduleId));
};
/******/ __webpack_require__.O(0, [152], function() {
- return __webpack_exec__(7070), __webpack_exec__(2938);
+ return __webpack_exec__(7070), __webpack_exec__(9915);
});
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;
timneutkens
force-pushed
the
jankaifer/nex-96-add-test-for-multiple-root-layouts
branch
from
December 13, 2022 11:11
d274027
to
9ef7af8
Compare
timneutkens
requested review from
styfle,
leerob,
steven-tey,
balazsorban44 and
padmaia
as code owners
December 13, 2022 11:11
ijjk
added
area: documentation
examples
Issue was opened via the examples template.
labels
Dec 13, 2022
timneutkens
force-pushed
the
jankaifer/nex-96-add-test-for-multiple-root-layouts
branch
from
December 13, 2022 11:27
9ef7af8
to
d274027
Compare
timneutkens
reviewed
Dec 16, 2022
timneutkens
reviewed
Dec 16, 2022
It seems to be broken in production and dev. Looking into it. |
|
…d-test-for-multiple-root-layouts
…d-test-for-multiple-root-layouts
timneutkens
approved these changes
Jan 5, 2023
timneutkens
deleted the
jankaifer/nex-96-add-test-for-multiple-root-layouts
branch
January 5, 2023 12:27
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Next.js team
PRs by the Next.js team.
examples
Issue was opened via the examples template.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test navigating between two root layouts and makes sure that we add they get switched correctly.