-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache package lock when running tests to speed up installation #44520
Merged
timneutkens
merged 7 commits into
vercel:canary
from
jankaifer:jankaifer/next-289-speed-up-installation-phase-of-running
Jan 3, 2023
Merged
Cache package lock when running tests to speed up installation #44520
timneutkens
merged 7 commits into
vercel:canary
from
jankaifer:jankaifer/next-289-speed-up-installation-phase-of-running
Jan 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankaifer
requested review from
timneutkens,
ijjk,
shuding,
styfle,
huozhi,
padmaia and
balazsorban44
as code owners
January 3, 2023 09:02
timneutkens
reviewed
Jan 3, 2023
timneutkens
approved these changes
Jan 3, 2023
timneutkens
approved these changes
Jan 3, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Stats from current PRDefault Build (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size Overall increase
|
vercel/next.js canary | JanKaifer/next.js jankaifer/next-289-speed-up-installation-phase-of-running | Change | |
---|---|---|---|
edge-ssr.js gzip | 110 kB | 110 kB | ✓ |
page.js gzip | 98.4 kB | 98.4 kB | |
Overall change | 209 kB | 209 kB |
Middleware size Overall increase ⚠️
vercel/next.js canary | JanKaifer/next.js jankaifer/next-289-speed-up-installation-phase-of-running | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 581 B | 582 B | |
middleware-r..fest.js gzip | 145 B | 145 B | ✓ |
middleware.js gzip | 27 kB | 27 kB | ✓ |
edge-runtime..pack.js gzip | 1.83 kB | 1.83 kB | ✓ |
Overall change | 29.6 kB | 29.6 kB |
Diffs
Diff for page.js
@@ -8618,16 +8618,16 @@ Learn More: https://nextjs.org/docs/messages/node-module-in-edge-runtime`;
/***/
},
- /***/ 1036: /***/ (
+ /***/ 199: /***/ (
__unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
) => {
Promise.resolve(/* import() eager */).then(
- __webpack_require__.bind(__webpack_require__, 1210)
+ __webpack_require__.bind(__webpack_require__, 2973)
);
Promise.resolve(/* import() eager */).then(
- __webpack_require__.bind(__webpack_require__, 2973)
+ __webpack_require__.bind(__webpack_require__, 1210)
);
Promise.resolve(/* import() eager */).then(
__webpack_require__.bind(__webpack_require__, 6448)
Diff for middleware-b..-manifest.js
@@ -9,7 +9,7 @@ self.__BUILD_MANIFEST = {
rootMainFiles: [
"static/chunks/webpack-c452a3e31b73f504.js",
"static/chunks/152-792c0b16c9234019.js",
- "static/chunks/main-app-c9a0aaff35eafcb5.js"
+ "static/chunks/main-app-ec4ed0640c5bbc2a.js"
],
pages: {
"/": [
Diff for main-app-HASH.js
@@ -1,16 +1,16 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[744],
{
- /***/ 9915: /***/ function(
+ /***/ 9421: /***/ function(
__unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
) {
Promise.resolve(/* import() eager */).then(
- __webpack_require__.t.bind(__webpack_require__, 429, 23)
+ __webpack_require__.t.bind(__webpack_require__, 1161, 23)
);
Promise.resolve(/* import() eager */).then(
- __webpack_require__.t.bind(__webpack_require__, 1161, 23)
+ __webpack_require__.t.bind(__webpack_require__, 429, 23)
);
Promise.resolve(/* import() eager */).then(
__webpack_require__.t.bind(__webpack_require__, 8138, 23)
@@ -28,7 +28,7 @@
return __webpack_require__((__webpack_require__.s = moduleId));
};
/******/ __webpack_require__.O(0, [152], function() {
- return __webpack_exec__(7070), __webpack_exec__(9915);
+ return __webpack_exec__(7070), __webpack_exec__(9421);
});
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;
timneutkens
approved these changes
Jan 3, 2023
jankaifer
deleted the
jankaifer/next-289-speed-up-installation-phase-of-running
branch
January 9, 2023 09:12
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pnpm-lock.yaml
intest/tmp
. It will do so just for tests that don't specify their own dependencies. Default dependencies work with typescript now so it shouldn't be an issue.It reduces the time for installation on subsequent runs from
3.5s
to.5s
So we get this in dev mode: