Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update json5 dependency to latest #44548

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Update json5 dependency to latest #44548

merged 2 commits into from
Jan 3, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 3, 2023

Updates to latest version of the dependency.

@eastwood
Copy link

eastwood commented Jan 3, 2023

Legend, came here to do this!

@ijjk ijjk merged commit 87c3578 into vercel:canary Jan 3, 2023
@ijjk ijjk deleted the update/json5-dep branch January 3, 2023 23:45
@eastwood
Copy link

eastwood commented Jan 4, 2023

Potentially still have issues via sub dependencies though:

image

@ijjk
Copy link
Member Author

ijjk commented Jan 4, 2023

That will need to be addressed upstream in https://github.com/import-js/eslint-plugin-import although isn't high urgency as the files it's loading are from the local filesystem and should not be from an untrusted source.

@eastwood
Copy link

eastwood commented Jan 4, 2023

Agreed :) Leaving the breadcrumb for others to follow :) Thanks mate

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants