Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: fix benchmark script #44592

Merged
merged 2 commits into from
Jan 5, 2023
Merged

misc: fix benchmark script #44592

merged 2 commits into from
Jan 5, 2023

Conversation

feedthejim
Copy link
Contributor

Fixing + doing some maintenance as I was using it for some things.

Changes:

  • fixed a bug related to how React is injected
  • added a progress tracker for the numbers of requests
  • retry on 500
  • added a param for crashing the lambda manually (useful for cold boots)
  • added a param to skip build, useful if you want to retest the same variation
  • don't crash when there's no data to compare

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Jan 5, 2023
@kodiakhq kodiakhq bot merged commit 2c23da0 into canary Jan 5, 2023
@kodiakhq kodiakhq bot deleted the update-bench-test branch January 5, 2023 13:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants