Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify middleware.ts location in docs #44788

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Conversation

stuartkeith
Copy link
Contributor

I had an issue where middleware stopped running. It turns out that because I had moved the pages directory from /pages to /src/pages, I also needed to move /middleware.ts to /src/middleware.ts.

While double checking the docs to figure out this problem, I interpreted the docs as saying middleware.ts could go in either the root or src. I thought swapping the sentence around would more clearly indicate middleware.ts must be alongside pages, wherever that is.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inverting this for clarity seems alright, thanks for the PR!

@ijjk ijjk merged commit 28afb88 into vercel:canary Jan 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants