Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relative app dir field #46393

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Add relative app dir field #46393

merged 1 commit into from
Feb 25, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 25, 2023

This adds a relative app dir field to the required files manifest so that we don't rely on absolute paths from a cached build since the cache can be restored in a separate context where the value no longer applies.

x-ref: #45864

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 25, 2023
@ijjk ijjk marked this pull request as ready for review February 25, 2023 00:50
@ijjk ijjk merged commit 4c6e8d4 into vercel:canary Feb 25, 2023
@ijjk ijjk deleted the add/relative-app-dir branch February 25, 2023 00:51
kodiakhq bot pushed a commit to vercel/vercel that referenced this pull request Feb 25, 2023
This leverages the relative app dir field in the required files manifest when available so that we don't rely on absolute paths from a cached build since the cache can be restored in a separate context where the value no longer applies.

x-ref: vercel/next.js#45864
x-ref: vercel/next.js#46393
x-ref: vercel/next.js#39432 (comment)
x-ref: [slack thread](https://vercel.slack.com/archives/C03S8ED1DKM/p1675821643786319)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant