Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: moduleResolution: bundler support in tsconfig.json #50289

Closed
wants to merge 3 commits into from
Closed

fix: moduleResolution: bundler support in tsconfig.json #50289

wants to merge 3 commits into from

Conversation

kevinwolfcr
Copy link
Contributor

@kevinwolfcr kevinwolfcr commented May 24, 2023 •
edited by timneutkens
Loading

Fixes #47858
link NEXT-1281

styfle
styfle reviewed May 26, 2023
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you add a test to confirm this work?

See #36189 for an example

@kevinwolfcr kevinwolfcr mentioned this pull request May 26, 2023
Closed
@kevinwolfcr
Copy link
Contributor Author

Thanks!

Can you add a test to confirm this work?

See #36189 for an example

Tests added here

@styfle
Copy link
Member

styfle commented May 26, 2023

Looks like CI is failing. Can we make sure this change is compatible with TS 4 as well?

@styfle styfle mentioned this pull request May 26, 2023
Merged
@louisgv louisgv mentioned this pull request May 28, 2023
Open
1 task
@styfle styfle mentioned this pull request May 30, 2023
Merged
@styfle styfle changed the title Add moduleResolution: bundler support fix: moduleResolution: bundler support in tsconfig.json May 30, 2023
kodiakhq bot pushed a commit that referenced this pull request Jun 8, 2023
@styfle
Bump to typescript@5.1 (#50557)
9a9d095 
We need to upgrade TypeScript to land the following fixes:

- #50289
- #48018

And it should fix async components:
- https://twitter.com/sebsilbermann/status/1664356039876124672

Also see this related TS 5.0 issue:

- microsoft/TypeScript#53402
@styfle styfle mentioned this pull request Jun 9, 2023
Merged
@kodiakhq kodiakhq bot closed this in #51065 Jun 9, 2023
kodiakhq bot pushed a commit that referenced this pull request Jun 9, 2023
@styfle @kevinwolfcr
fix: moduleResolution: bundler support in tsconfig.json (#51065)
1a0b5d2 
- Fixes #47858
- Closes #50289

fix #47858
fix NEXT-1281

Co-authored-by: Kevin Wolf <3157426+kevinwolfcr@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NEXT-1281] Support moduleResolution bundler in tsconfig.json
3 participants
@kevinwolfcr @styfle @ijjk