Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock node version to 18.16 #52894

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Lock node version to 18.16 #52894

merged 3 commits into from
Jul 19, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jul 19, 2023

As we're using nodejs with latest version of 18.x on CI, there's a new behavior change of url.fileURLToPath that didn't join the paths as expected

locally with node 16.x or 18.16

/private/var/folders/mh/y8kwzkls6v3_w3_k6q384cw80000gn/T/next-install-b033b516612809c6fb0a0de77c6e50f7d7f8af34dfd3d01812b99345352dc992/node_modules/.pnpm/file+..+next-repo-7e52b07043e986127273a2d951e5c412b0dd45fb24eb34001bd372e2afff79db+packages+n_vyqu6i4c4i3efp5pqsaeaoe5s4/node_modules/next/dist/compiled/@vercel/og/noto-sans-v27-latin-regular.ttf

in the actions runner with node 18.17 it's

/tmp/next-install-8efaa47c1546bed07990d8f130decceb6536e1a36146e7885cb68e3c3dea21f7/node_modules/.pnpm/file+..+next-repo-9679355e05341947e7aa0b42c994e3ac_krcuriy4thl7zawouf7sswlrgy/node_modules/next/dist/compiled/@vercel/og/index.node.js/../noto-sans-v27-latin-regular.ttf

You can see that index.node.js is still present in the path as a folder which is unexpected

index.node.js/../

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Jul 19, 2023
ztanner
ztanner previously approved these changes Jul 19, 2023
@kachkaev
Copy link
Contributor

Out of curiosity: what problem does this solve?

@huozhi
Copy link
Member Author

huozhi commented Jul 19, 2023

@kachkaev will update later in the description if it passes in the end and when undraft

updated in the description

@huozhi huozhi marked this pull request as ready for review July 19, 2023 16:14
@huozhi huozhi requested review from a team as code owners July 19, 2023 16:14
@huozhi huozhi requested review from manovotny, molebox and ztanner July 19, 2023 16:14
@kodiakhq kodiakhq bot merged commit 31453fa into canary Jul 19, 2023
@kodiakhq kodiakhq bot deleted the lock-node-version branch July 19, 2023 16:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants