Open Graph Image font declaration moved to correct place #53998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylemcd
requested review from
timneutkens,
ijjk,
shuding,
styfle,
huozhi and
a team
as code owners
styfle
approved these changes
Aug 14, 2023
altano
added a commit
to altano/alan.norbauer.com
that referenced
this pull request
Aug 15, 2023
Seeing if vercel/next.js#53998 is right?
altano
added a commit
to altano/alan.norbauer.com
that referenced
this pull request
Aug 16, 2023
Seeing if vercel/next.js#53998 is right?
altano
added a commit
to altano/alan.norbauer.com
that referenced
this pull request
Aug 20, 2023
Seeing if vercel/next.js#53998 is right?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing
opengraph-imagein my personal-site-project. I was consistently running into issues where custom fonts would either only work locally or only work on vercel. To me it seemed like differences in pathing inedgevsnodejsruntimes. After digging around I found issue #48081, more specifically this comment where moving thefetchfor the font into theImagefunction solved the issue.I'm not sure if this is 100% the correct fix, or if this is an issue that needs to be solved in another way. If that's not the case this PR updates the documentation around
opengraph-imageto have the fetch for custom fonts inside of theImagefunction.