Fix missing custom headers and cache-control header for /_next/static #54779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosieLq
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
cosieLq
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix a quite unexpected behaviour.
That is, when i18n is not configured in next.config, the server returns custom headers specified in next.config in the response for static assets (/_next/static). Whereas the server returns no custom headers when i18n is configured.
This inconsistency is especially an issue when the missing headers are security related.
Another related issue is: without i18n, the server respects the cache-control header in next.config somehow for static assets and does not overwrite it as mentioned here in https://nextjs.org/docs/pages/building-your-application/deploying/production-checklist#caching. With i18n, the cache-control header is indeed overwritten.
These inconsistencies seem to spread over dev, start and standalone mode.
Fixes #54159