Fix(i18n): Inaccessible public folder on non-default domains

[pekarja5]

Changes in #52492 made public folder accessible only on default domain if using i18n. PR fixes this by making public directory contents accessible from all i18n domains as the original solution did.

Fixes #54765

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: acf43f4

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: acf43f4

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[orca-security-us]

Orca Security Scan Summary

Status	Check	Issues by priority
Passed	Secrets	0   1   0   0	View in Orca

[bobbonius]

Hi there! My colleague created the issue you're referencing and I was wondering if I could be of any assistance to get this through? We want to go to next 13 but this issue is holding us back at the moment.

[pekarja5]

@bobbonius There is nothing to do apart from waiting for it to get merged. The fix is really simple as it is just one line edit. It is already approved so i hope it will get merged and released soon.

[bobbonius]

There is nothing to do apart from waiting for it to get merged. The fix is really simple as it is just one line edit. It is already approved so i hope it will get merged and released soon.

Thanks!

[aledovskikh]

Hey! When it'll be released? Looks like this is some kind of critical bug

[adri]

@timneutkens sorry for tagging you directly! If you do have a minute to check this PR it would be amazing. It blocks us from upgrading next.js our static assets are gone on most domains.

[chrisneven]

This is blocking us as well at the moment. It would be really nice if we could get this one true!

[chrisneven]

@ijjk, maybe you can take a look at this? Since you made the change initially

Thanks in advance!

[timneutkens]

This PR is missing tests, please have a look at and follow the PR template to ensure the changes can be reviewed correctly.

[pekarja5]

@timneutkens Does the test suite even supports testing access to multiple domains? I could not find any test with such functionality.

The goal is to make the test access files in public directory from multiple defined locale domains. If anyone has any tips how to make such test feel free to give me some ideas.

[aledovskikh]

Is there any chance to fix and merge it to nearest release?
We can't upgrade NextJS upper than 13.4.7 because of this bug

[glenngijsberts]

@pekarja5 could you please update the description of this PR?

@timneutkens sorry for tagging again, but any chance you can give some guidance on how to test this (personally I don't know)?

[pekarja5]

@glenngijsberts Some changes in particular?

[glenngijsberts]

@pekarja5 like Tim said, follow the PR template please. You can start creating a PR (without actually creating it) to see what the template is, or in this file.

[pekarja5]

@glenngijsberts the PR template wants me to describe the problem it solves and reference the issue it fixes, to contain tests and to attach a link for errors.
The issue is already linked, problem is described, tests are not present, because i cannot see a way to test this particular case and no errors are introduced by the changes.

So the thing this PR is missing is the test.

[aledovskikh]

timneutkens Any progress of releasing this fix for issue? It is probably critical bug for projects with I18n.
Same PR here #59773

[persocon]

lol, just upgraded my nextjs version to 14 and now i'm having this exact problem, when will this PR be updated and merged? 🙏

[ijjk]

Hi, this would match all locales and not jut the locale domains/default locale. Continuing fix/tests in #60749