Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logging option to stable #56791

Merged
merged 7 commits into from
Oct 23, 2023
Merged

Move logging option to stable #56791

merged 7 commits into from
Oct 23, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Oct 13, 2023

We introduced a data fetching logging before, and the control option was under experimental. After a bit experiments turns out users really loves it. We decide to move it to a stable option.

Changes

We're going to move the logging option outside of experimental, and scope the fetches related config under logging.fetches.

// next.config.js
logging?: {
    fetches?: {
      fullUrl?: boolean
    }
}

@ijjk
Copy link
Member

ijjk commented Oct 13, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js logging-option Change
buildDuration 10.6s 10.8s ⚠️ +124ms
buildDurationCached 6.2s 6.2s N/A
nodeModulesSize 174 MB 174 MB N/A
nextStartRea..uration (ms) 519ms 525ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js logging-option Change
199-HASH.js gzip 27.9 kB 27.9 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 33 kB 33 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js logging-option Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js logging-option Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary vercel/next.js logging-option Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js logging-option Change
index.html gzip 528 B 529 B N/A
link.html gzip 541 B 541 B
withRouter.html gzip 523 B 522 B N/A
Overall change 541 B 541 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js logging-option Change
edge-ssr.js gzip 95.7 kB 95.7 kB N/A
page.js gzip 158 kB 158 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js logging-option Change
middleware-b..fest.js gzip 623 B 624 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: e2538b8

@ijjk
Copy link
Member

ijjk commented Oct 20, 2023

Tests Passed

@huozhi huozhi changed the title (wip) Move logging option to stable Move logging option to stable Oct 23, 2023
@huozhi huozhi marked this pull request as ready for review October 23, 2023 17:03
timneutkens
timneutkens previously approved these changes Oct 23, 2023
@kodiakhq kodiakhq bot merged commit 4e14291 into canary Oct 23, 2023
53 of 58 checks passed
@kodiakhq kodiakhq bot deleted the logging-option branch October 23, 2023 18:45
@github-actions github-actions bot added the locked label Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants