Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop undici #56899

Merged
merged 4 commits into from
Oct 19, 2023
Merged

chore: drop undici #56899

merged 4 commits into from
Oct 19, 2023

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Oct 16, 2023

What?

Note: This is not a breaking change, just removing some unused code.

Why?

Since #56896 we don't need this, as Node.js 18+ has fetch exposed by default.

How?

Depends on #56896, #56909

We already didn't load fetch if globalThis had it (ie. Node.js 18+ environments), and since we are dropping support for Node.js 16, these code paths should have no effect on runtime behavior.

See: https://nodejs.org/docs/latest-v18.x/api/globals.html#fetch

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 16, 2023
@ijjk
Copy link
Member

ijjk commented Oct 16, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Oct 16, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js chore/drop-undici Change
buildDuration 10.4s 10.4s N/A
buildDurationCached 6.1s 6s N/A
nodeModulesSize 175 MB 174 MB N/A
nextStartRea..uration (ms) 530ms 513ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js chore/drop-undici Change
199-HASH.js gzip 27.5 kB 27.5 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.3 kB 45.3 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.8 kB 98.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/drop-undici Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js chore/drop-undici Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.36 kB 4.36 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.08 kB 1.08 kB
Client Build Manifests
vercel/next.js canary vercel/next.js chore/drop-undici Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/drop-undici Change
index.html gzip 529 B 529 B
link.html gzip 544 B 542 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 529 B 529 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js chore/drop-undici Change
edge-ssr.js gzip 93.7 kB 93.7 kB N/A
page.js gzip 155 kB 155 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js chore/drop-undici Change
middleware-b..fest.js gzip 624 B 623 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.5 kB 22.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: 0ff6487

package.json Outdated Show resolved Hide resolved
kodiakhq bot pushed a commit that referenced this pull request Oct 19, 2023
### What?

Upgrade jest to its latest version

### Why?

#56899 fails because historically Jest stripped the globals in Node.js, but 28+ isn't doing that anymore. If we upgrade, we don't have to keep track of Node.js globals and when they are added. This will be useful in removing even more polyfills for things that are natively shipped in Node.js now.

### How?

Jest 29 introduced a change to the snapshot format: https://jestjs.io/blog/2022/08/25/jest-29

First, I tried setting the old compat option to not require updating snapshots, but some tests were still failing: https://dev.azure.com/nextjs/next.js/_build/results?buildId=70633&view=logs&j=8af7cf9c-43a1-584d-6f5c-57bad8880974&t=7ae70e63-3625-50f4-6764-5b3e72b4bd7a&l=273 So going through the pain now instead.
@balazsorban44 balazsorban44 marked this pull request as ready for review October 19, 2023 18:14
@kodiakhq kodiakhq bot merged commit 4c46ddd into canary Oct 19, 2023
56 of 60 checks passed
@kodiakhq kodiakhq bot deleted the chore/drop-undici branch October 19, 2023 18:35
kodiakhq bot pushed a commit that referenced this pull request Oct 20, 2023
### What?

Dropping `form-data` polyfill as Node.js 18+ versions all expose it on `globalThis`

### Why?

Reduce the amount of shipped code in Next.js

### How?

Similar to #56899

See: https://nodejs.org/docs/latest-v18.x/api/globals.html#class-formdata
@github-actions github-actions bot added the locked label Nov 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants