chore(next/image)!: mark onLoadingComplete as deprecated in favor of onLoad

[styfle]

History

We used to pass onLoad through directly to the underlying img so onLoadingComplete was introduced in order to handle the case when placeholder="blur" was used and onLoad would trigger before the placeholder was removed.

We have since changed the behavior of onLoad so that it acts the same as onLoadingComplete and therefore onLoadingComplete is no longer needed.

What is this PR doing?

This PR marks onLoadingComplete as deprecated in favor of onLoad. In the future, we may remove onLoadingComplete.

[ijjk]

Stats from current PR

Default Build

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js styfle/next-1688-mark-onloadingcomplete-as-deprecated	Change
buildDuration	10.3s	10.4s	⚠️ +106ms
buildDurationCached	6.1s	6.2s	N/A
nodeModulesSize	174 MB	174 MB	⚠️ +1.26 kB
nextStartRea..uration (ms)	527ms	534ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js styfle/next-1688-mark-onloadingcomplete-as-deprecated	Change
199-HASH.js gzip	27.5 kB	27.5 kB	✓
3f784ff6-HASH.js gzip	53.1 kB	53.1 kB	✓
99.HASH.js gzip	182 B	182 B	✓
framework-HASH.js gzip	45.3 kB	45.3 kB	✓
main-app-HASH.js gzip	254 B	251 B	N/A
main-HASH.js gzip	32.9 kB	32.9 kB	N/A
webpack-HASH.js gzip	1.75 kB	1.75 kB	N/A
Overall change	126 kB	126 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js styfle/next-1688-mark-onloadingcomplete-as-deprecated	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js styfle/next-1688-mark-onloadingcomplete-as-deprecated	Change
_app-HASH.js gzip	206 B	205 B	N/A
_error-HASH.js gzip	182 B	180 B	N/A
amp-HASH.js gzip	506 B	505 B	N/A
css-HASH.js gzip	322 B	323 B	N/A
dynamic-HASH.js gzip	2.57 kB	2.57 kB	N/A
edge-ssr-HASH.js gzip	260 B	259 B	N/A
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	369 B	369 B	✓
image-HASH.js gzip	4.35 kB	4.35 kB	N/A
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.64 kB	2.63 kB	N/A
routerDirect..HASH.js gzip	312 B	311 B	N/A
script-HASH.js gzip	385 B	384 B	N/A
withRouter-HASH.js gzip	307 B	308 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	1.08 kB	1.08 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js styfle/next-1688-mark-onloadingcomplete-as-deprecated	Change
_buildManifest.js gzip	485 B	482 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js styfle/next-1688-mark-onloadingcomplete-as-deprecated	Change
index.html gzip	528 B	530 B	N/A
link.html gzip	541 B	542 B	N/A
withRouter.html gzip	523 B	524 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js styfle/next-1688-mark-onloadingcomplete-as-deprecated	Change
edge-ssr.js gzip	93.6 kB	93.6 kB	N/A
page.js gzip	154 kB	154 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js styfle/next-1688-mark-onloadingcomplete-as-deprecated	Change
middleware-b..fest.js gzip	626 B	623 B	N/A
middleware-r..fest.js gzip	150 B	151 B	N/A
middleware.js gzip	22.5 kB	22.5 kB	N/A
edge-runtime..pack.js gzip	1.92 kB	1.92 kB	✓
Overall change	1.92 kB	1.92 kB	✓

Commit: 21697ee

[ijjk]

Tests Passed

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: 704d54d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: 704d54d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer