Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test sharp 0.33.0-alpha.9 #57007

Closed
wants to merge 2 commits into from
Closed

Conversation

styfle
Copy link
Member

@styfle styfle commented Oct 18, 2023

Testing per this comment: lovell/sharp#3750 (comment)

@ijjk ijjk added area: tests created-by: Next.js team PRs by the Next.js team. labels Oct 18, 2023
@ijjk
Copy link
Member

ijjk commented Oct 18, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Oct 18, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js try-with-sharp-0.33.0-alpha.9 Change
buildDuration 10.5s 11.7s ⚠️ +1.2s
buildDurationCached 7.7s 6.1s N/A
nodeModulesSize 174 MB 174 MB
nextStartRea..uration (ms) 517ms 542ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js try-with-sharp-0.33.0-alpha.9 Change
199-HASH.js gzip 27.5 kB 27.5 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.3 kB 45.3 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.8 kB 98.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js try-with-sharp-0.33.0-alpha.9 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js try-with-sharp-0.33.0-alpha.9 Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.35 kB 4.35 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.08 kB 1.08 kB
Client Build Manifests
vercel/next.js canary vercel/next.js try-with-sharp-0.33.0-alpha.9 Change
_buildManifest.js gzip 485 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js try-with-sharp-0.33.0-alpha.9 Change
index.html gzip 527 B 529 B N/A
link.html gzip 541 B 542 B N/A
withRouter.html gzip 523 B 524 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js try-with-sharp-0.33.0-alpha.9 Change
edge-ssr.js gzip 93.6 kB 93.6 kB N/A
page.js gzip 154 kB 154 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js try-with-sharp-0.33.0-alpha.9 Change
middleware-b..fest.js gzip 624 B 622 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.5 kB 22.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: 89176ac

@styfle styfle closed this in #60226 Jan 4, 2024
styfle added a commit that referenced this pull request Jan 4, 2024
This test was changed in #59074
because the latest sharp stopped working with yarn. However, we can
update these tests to use npm instead and continue testing the latest
sharp.
 
Closes NEXT-1986

Closes #57007
@styfle styfle deleted the try-with-sharp-0.33.0-alpha.9 branch January 4, 2024 19:46
agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
This test was changed in vercel#59074
because the latest sharp stopped working with yarn. However, we can
update these tests to use npm instead and continue testing the latest
sharp.
 
Closes NEXT-1986

Closes vercel#57007
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants