Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update route handler documentation on how to set cookies #57052

Closed
wants to merge 2 commits into from

Conversation

joulev
Copy link
Contributor

@joulev joulev commented Oct 19, 2023

Why?

The route handler documentation currently still says the recommended way to set cookies is by manually constructing a Set-Cookie header. It used to be necessary, but that is no longer the case since cookies() mutation methods work in route handlers now.

Signed-off-by: Vu Van Dung <me@joulev.dev>
@joulev joulev requested review from a team as code owners October 19, 2023 12:38
@joulev joulev requested review from jh3y and leerob and removed request for a team October 19, 2023 12:38
@ijjk
Copy link
Member

ijjk commented Oct 19, 2023

Allow CI Workflow Run

  • approve CI run for commit: ae1a9d4

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

2 similar comments
@ijjk
Copy link
Member

ijjk commented Oct 19, 2023

Allow CI Workflow Run

  • approve CI run for commit: ae1a9d4

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Oct 19, 2023

Allow CI Workflow Run

  • approve CI run for commit: ae1a9d4

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@leerob
Copy link
Member

leerob commented Dec 24, 2023

Replaced with #59915

@leerob leerob closed this Dec 24, 2023
@joulev joulev deleted the update-route-handler-set-cookie branch December 24, 2023 18:19
agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
@github-actions github-actions bot added the locked label Jan 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants