-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route Handler Types #57070
Merged
Merged
Route Handler Types #57070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
wyattjoh
force-pushed
the
feat/route-handler
branch
from
October 19, 2023 18:30
9b9bc19
to
f442f46
Compare
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Diff detailsDiff for page.jsDiff too large to display Diff for edge-ssr.jsDiff too large to display |
wyattjoh
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim and
ztanner
as code owners
October 19, 2023 18:45
ijjk
previously approved these changes
Oct 20, 2023
wyattjoh
force-pushed
the
feat/route-handler
branch
from
October 20, 2023 20:18
fdbeb9d
to
7e26654
Compare
Tests Passed |
ijjk
previously approved these changes
Oct 20, 2023
wyattjoh
force-pushed
the
feat/route-handler
branch
from
October 20, 2023 20:24
7e26654
to
ff855b4
Compare
ijjk
approved these changes
Oct 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the handle functions on the server to share a common type that simplifies the signature.