Update CNA tests more #57088
Merged
Update CNA tests more #57088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
requested review from
timneutkens,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
huozhi
previously approved these changes
Oct 19, 2023
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
|
styfle
reviewed
Oct 19, 2023
| if (p.match(/static[/\\]media/)) { | ||
| return '' | ||
| } | ||
| return null |
There was a problem hiding this comment.
Did you intend to change this line?
There was a problem hiding this comment.
Yeah attempting to fix flake with ENOENT can move to a separate PR
styfle
reviewed
Oct 19, 2023
|
|
||
| import { useTempDir } from '../../lib/use-temp-dir' | ||
| import { fetchViaHTTP, findPort, killApp, launchApp } from 'next-test-utils' | ||
| import resolveFrom from 'resolve-from' | ||
| //import { createNextInstall } from '../../lib/create-next-install' |
There was a problem hiding this comment.
Similarly here - was this intended?
There was a problem hiding this comment.
Yeah no need to keep the comment around as we have the TODO
ijjk
force-pushed
the
update/other-tests
branch
from
70a8304 to
d94c575
Compare
huozhi
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #57025 this updates other places we run the
create-next-appCLI in tests.