Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: memory usage tweaks #57163

Merged
merged 2 commits into from
Oct 23, 2023
Merged

perf: memory usage tweaks #57163

merged 2 commits into from
Oct 23, 2023

Conversation

feedthejim
Copy link
Contributor

This PR does two things:

  • bring back the logic to restart the dev server when approaching 80% of the heap limits
  • add some logic to increase the default Node.js memory usage to 50% of the available RAM

Tested manually

@ijjk
Copy link
Member

ijjk commented Oct 21, 2023

Failing test suites

Commit: 8b9ddfb

pnpm test test/integration/build-indicator/test/index.test.js

  • Build Activity Indicator > Enabled > Shows the build indicator when a page is built during navigation
Expand output

● Build Activity Indicator › Enabled › Shows the build indicator when a page is built during navigation

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |       await waitFor(500)
  82 |       const wasVisible = await browser.eval('window.showedBuilder')
> 83 |       expect(wasVisible).toBe(true)
     |                          ^
  84 |       await browser.close()
  85 |     })
  86 |

  at Object.toBe (integration/build-indicator/test/index.test.js:83:26)

Read more about building and testing Next.js in contributing.md.

ijjk
ijjk previously approved these changes Oct 21, 2023
@ijjk
Copy link
Member

ijjk commented Oct 21, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feedthejim/memory-tweaks Change
buildDuration 10.7s 10.7s N/A
buildDurationCached 6.2s 6.1s N/A
nodeModulesSize 174 MB 174 MB ⚠️ +7.39 kB
nextStartRea..uration (ms) 499ms 496ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js feedthejim/memory-tweaks Change
199-HASH.js gzip 27.6 kB 27.7 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.3 kB 45.3 kB
main-app-HASH.js gzip 253 B 252 B N/A
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.8 kB 98.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feedthejim/memory-tweaks Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js feedthejim/memory-tweaks Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.36 kB 4.36 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.08 kB 1.08 kB
Client Build Manifests
vercel/next.js canary vercel/next.js feedthejim/memory-tweaks Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js feedthejim/memory-tweaks Change
index.html gzip 529 B 528 B N/A
link.html gzip 541 B 543 B N/A
withRouter.html gzip 523 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js feedthejim/memory-tweaks Change
edge-ssr.js gzip 93.8 kB 93.8 kB N/A
page.js gzip 155 kB 155 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js feedthejim/memory-tweaks Change
middleware-b..fest.js gzip 626 B 623 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: 8b9ddfb

Base automatically changed from feedthejim/fix-inspect to canary October 21, 2023 00:49
@kodiakhq kodiakhq bot dismissed ijjk’s stale review October 21, 2023 00:49

The base branch was changed.

@feedthejim feedthejim force-pushed the feedthejim/memory-tweaks branch from cef6c95 to 057d561 Compare October 21, 2023 23:41
@feedthejim feedthejim merged commit 1836998 into canary Oct 23, 2023
55 of 58 checks passed
@feedthejim feedthejim deleted the feedthejim/memory-tweaks branch October 23, 2023 00:26
@github-actions github-actions bot added the locked label Nov 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants