-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SCSS and SCSS loader handling tests for Turbopack #57192
Merged
kodiakhq
merged 4 commits into
canary
from
10-21-Fix_SCSS_and_SCSS_loader_handling_tests_for_Turbopack
Oct 21, 2023
Merged
Fix SCSS and SCSS loader handling tests for Turbopack #57192
kodiakhq
merged 4 commits into
canary
from
10-21-Fix_SCSS_and_SCSS_loader_handling_tests_for_Turbopack
Oct 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
October 21, 2023 19:29
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
|
sokra
approved these changes
Oct 21, 2023
…sts_for_Turbopack
…sts_for_Turbopack
kodiakhq
bot
deleted the
10-21-Fix_SCSS_and_SCSS_loader_handling_tests_for_Turbopack
branch
October 21, 2023 20:45
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests depend on the order of test runs in order to run, so they fail if the first test has not run. This ensures it's skipped for the others.